Netcdf multiple samples a day #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdries
requested changes
Feb 27, 2024
| Duration.between(fixedTimeOffset, key.time).getSeconds % secondsPerDay != 0 | ||
| case _ => | ||
| false | ||
| }).isEmpty()) TemporalResolution.days else TemporalResolution.seconds |
There was a problem hiding this comment.
I'm afraid that doing this on the rdd triggers an extra job in Spark.
Suggestion would be to just choose the resolution when you create the filename. Consequence is that in theory, filename format could change.
There was a problem hiding this comment.
Merged the NetCDF part, the Tiff part is split to a different MR: #269
| Duration.between(fixedTimeOffset, key.time).getSeconds % secondsPerDay != 0 | ||
| case _ => | ||
| false | ||
| }).isEmpty()) TemporalResolution.days else TemporalResolution.seconds |
There was a problem hiding this comment.
I'm afraid that doing this on the rdd triggers an extra job in Spark.
Suggestion would be to just choose the resolution when you create the filename. Consequence is that in theory, filename format could change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tiff and netcdf.
When saving the tiles, we usually round the date to daily resolution.
Now, when there is a date that does not exactly match midnight, we assume the temporal resolution is higher, and we save the results with seconds in resolution.
For tiff export, the ':' in the date part is replaced with '-', to avoid problems on Windows file systems: Example
openEO_2017-01-01T01-00-00Z.tifI used
ISO_ZONED_DATE_TIMEin the filename. Following an example I found ingeotiff/package.scale