openeo grass driver #114
openeo grass driver #114
Conversation
use metadata from actinia instead of guessing
| for bandname in bandlist: | ||
| # not so nice, better use different name and common_name | ||
| # waiting for GRASS GIS | ||
| bands.append(EOBands(name=bandname, common_name=bandname)) |
There was a problem hiding this comment.
This assumes that the band names equal always common band names, right? How many common band names are there? Could we make a list of them and if bandname is contained in it, we set it also for common_name and if not, it is empty or unknown?
There was a problem hiding this comment.
In this context, we only get a list of band names from t.info. In TGIS, there is only a single field band_reference, thus we get only one band name per raster and use it as both name and common_name.
A list of common band names in the EO STAC extension is here: https://github.com/stac-extensions/eo/#common-band-names
There was a problem hiding this comment.
Yes - I meant that it can be the case that the user specifies a band_reference which is not a common band name but nevertheless it would appear in this field then. To prevent this, a check could be implemented to compare the field with all common band names and only set it then, otherwise leave it empty.
* get platform and instrument
use metadata from actinia instead of guessing