Integrate actinia stac collections #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcjansen
reviewed
Nov 17, 2021
src/openeo_grass_gis_driver/actinia_processing/actinia_interface.py
Outdated
Show resolved
Hide resolved
src/openeo_grass_gis_driver/actinia_processing/actinia_interface.py
Outdated
Show resolved
Hide resolved
src/openeo_grass_gis_driver/actinia_processing/actinia_interface.py
Outdated
Show resolved
Hide resolved
src/openeo_grass_gis_driver/actinia_processing/actinia_interface.py
Outdated
Show resolved
Hide resolved
| try: | ||
| license = i['license'] | ||
| except Exception: | ||
| license = "proprietary" |
There was a problem hiding this comment.
Or unknown? You decide.
There was a problem hiding this comment.
"proprietary" is currently the default in the existing implementation, so I would rather not change it.
…ce.py Co-authored-by: Marc Jansen <jansen@terrestris.de>
…ce.py Co-authored-by: Marc Jansen <jansen@terrestris.de>
Co-authored-by: Marc Jansen <jansen@terrestris.de>
…ce.py Co-authored-by: Marc Jansen <jansen@terrestris.de>
…ce.py Co-authored-by: Marc Jansen <jansen@terrestris.de>
|
I don't know why the codeql checks keep staying in pending. I will merge now, in the actions overview it looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the implementation of actinia-stac-plugin and this PR, it is now possible to also request STAC collections registered in actinia. They will be integrated in the collections list and can be requested by id.
For this feature to work, actinia needs to be installed with the actinia-stac-plugin. If it is not installed, the STAC collections are simply not included in the
/collectionsresponse (like before)."Normal" STRDS:
STAC collection:
There are some differences in attributes but I decided to not use the
CollectionInformation. See more detailed explanation why in comment insrc/openeo_grass_gis_driver/collection_information.py