Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array_modify: Change the default value for length from 1 to 0. #421

Merged
merged 1 commit into from
Mar 15, 2023
Merged

array_modify: Change the default value for length from 1 to 0. #421

merged 1 commit into from
Mar 15, 2023

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Mar 14, 2023

Fixes #312

@m-mohr m-mohr added this to the 2.0.0 milestone Mar 14, 2023
@m-mohr m-mohr marked this pull request as ready for review March 14, 2023 17:26
@m-mohr m-mohr linked an issue Mar 14, 2023 that may be closed by this pull request
array_modify: Change default value of length? #312
Closed
LukeWeidenwalker
LukeWeidenwalker approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@LukeWeidenwalker LukeWeidenwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

soxofaan
soxofaan approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m-mohr m-mohr merged commit 13bee5f into draft Mar 15, 2023
@m-mohr m-mohr deleted the issue-312 branch March 15, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan soxofaan approved these changes

@LukeWeidenwalker LukeWeidenwalker LukeWeidenwalker approved these changes

@clausmichele clausmichele Awaiting requested review from clausmichele

@dthiex dthiex Awaiting requested review from dthiex

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

array_modify: Change default value of length?
3 participants
@m-mohr @soxofaan @LukeWeidenwalker