Handle units in vector processes #330 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
requested review from
soxofaan,
edzer,
jdries,
aljacob,
LukeWeidenwalker,
metzm,
dthiex and
mkadunc
clausmichele
approved these changes
May 3, 2023
soxofaan
reviewed
May 3, 2023
m-mohr
requested review from
neteler,
christophreimer,
LukeWeidenwalker,
clausmichele,
zcernigoj and
ValentinaHutter
mkadunc
approved these changes
May 3, 2023
LukeWeidenwalker
approved these changes
May 4, 2023
dthiex
requested changes
May 4, 2023
Co-authored-by: Daniel Thiex <60705209+dthiex@users.noreply.github.com>
neteler
reviewed
May 4, 2023
| @@ -22,7 +22,7 @@ | |||
| }, | |||
| { | |||
| "name": "distance", | |||
| "description": "The distance of the buffer in the unit of the spatial reference system. A positive distance expands the geometries and results in outward buffering (dilation) while a negative distance shrinks the geometries and results in inward buffering (erosion).", | |||
| "description": "The distance of the buffer in meters. If the unit of the spatial reference system is not meters, a `UnitMismatch` error is thrown. Use ``vector_reproject()`` to convert the geometries to a suitable spatial reference system.\n\nA positive distance expands the geometries and results in outward buffering (dilation) while a negative distance shrinks the geometries and results in inward buffering (erosion).", | |||
There was a problem hiding this comment.
Too late since it is already merged, but the wording could be:
A positive distance expands the geometries, resulting in outward buffering (dilation), while a negative distance shrinks the geometries, resulting in inward buffering (erosion).
There was a problem hiding this comment.
I can still integrate that later, thanks :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #330 as discussed there and in #414.
I tried to make this as future-proof as possible so that we can decide to allow more than meters in the future.
A general question came up (how to encode values with units), please chime in here: #436 (comment)