-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding imaginary unit #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, thanks..
Couple of comments for consistency and for linting.
Also, please make the PR against draft, not master.
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Done, thanks for the suggestions Matthias. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to recreate this PR, I think. You can't merge master into draft, otherwise other commits will be included.
The commit list must be clean: https://github.com/Open-EO/openeo-processes/pull/456/commits
Otherwise, looks good.
Adding a process expressing the imaginary unit. First step towards complex numbers in openEO.