Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execute_batch silently adds save_result even if there is already one #401

Open
soxofaan opened this issue Mar 24, 2023 · 3 comments
Open

execute_batch silently adds save_result even if there is already one #401

soxofaan opened this issue Mar 24, 2023 · 3 comments
Labels
api compliancy bug

Comments

@soxofaan
Copy link
Member 

cube = cube.save_result(format="NetCDF")
cube.execute_batch()

the last execute_batch() call will silently add a save_result("GTiff") causing to post a process graph with two save_result nodes (in series), which is not intended by the user and not valid either (Open-EO/openeo-processes#334)
@soxofaan soxofaan mentioned this issue Mar 24, 2023
Open
soxofaan added a commit that referenced this issue Mar 28, 2023
@soxofaan
Issue #401 Improve automatic adding of save_result
8620d9d
@soxofaan soxofaan mentioned this issue Mar 28, 2023
Closed
soxofaan added a commit that referenced this issue Mar 29, 2023
@soxofaan
Issue #401 Improve automatic adding of save_result
b428d2b
@clausmichele clausmichele mentioned this issue Mar 29, 2023
Closed
soxofaan added a commit that referenced this issue Apr 5, 2023
@soxofaan
Issue #401 Improve automatic adding of save_result
bdea97d
soxofaan added a commit that referenced this issue Apr 11, 2023
@soxofaan
Issue #401 Improve automatic adding of save_result
0f10972
soxofaan added a commit that referenced this issue Apr 11, 2023
@soxofaan
Issue #401 WIP
394624d
@soxofaan soxofaan mentioned this issue Apr 11, 2023
Draft
soxofaan added a commit that referenced this issue Apr 12, 2023
@soxofaan
Issue #401 Improve automatic adding of save_result
90381bc
soxofaan added a commit that referenced this issue Apr 12, 2023
@soxofaan
Issue #401 WIP
93fc7d5
soxofaan added a commit that referenced this issue Apr 12, 2023
@soxofaan
fixup! Issue #401 Improve automatic adding of save_result
6962eb3
soxofaan added a commit that referenced this issue Apr 12, 2023
@soxofaan
Issue #401 Improve automatic adding of save_result
fa3a4d2
soxofaan added a commit that referenced this issue Apr 12, 2023
@soxofaan
Issue #401 WIP
9c4cbd4
@soxofaan
Copy link
Member Author

reopening: still has to be addressed for VectorCubes (and related)

started WIP in #415 already

@soxofaan soxofaan reopened this Apr 12, 2023
@soxofaan soxofaan mentioned this issue Jul 14, 2023
Closed
soxofaan added a commit that referenced this issue Jul 14, 2023
@soxofaan
Issue #401 add tests for current behavior of VectorCube.download
35bd4eb
soxofaan added a commit that referenced this issue Jul 14, 2023
@soxofaan
Issue #401 avoid double save_result nodes with VectorCube.download
8cbaf25
@soxofaan
Copy link
Member Author

Already avoided double save_result with VectorCube.save_result + .download() in 8cbaf25

still some more work to do: make this feature more generic, like in WIP PR #415

soxofaan added a commit that referenced this issue Jul 17, 2023
@soxofaan
Issue #401/#449 support format guessing in VectorCube.download
4971005
@soxofaan
Copy link
Member Author

addressing #402 will probably simplify and help with the unification of this feature

soxofaan added a commit that referenced this issue Jul 18, 2023
@soxofaan
Issue #401/#449 support format guessing in VectorCube.execute_batch
31766cb
soxofaan added a commit that referenced this issue Jul 19, 2023
@soxofaan
Minor doc updates on output format guessing in VectorCube #401/#449
42d0062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api compliancy bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soxofaan