Start supporting custom job databases in MultiBackendJobManager #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
openeo/extra/job_management.py
Outdated
|
|
||
| def persist(self, df: pd.DataFrame): | ||
| """Store job data to the database.""" | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
Is there a reason not to make this a formal interface? As a user it might be beneficial to immediately get thrown an error if your custom class doesn't have all necessary methods.
There was a problem hiding this comment.
Indeed, now that we are making this interface more public, that would be useful
soxofaan
commented
Jul 19, 2024
soxofaan
force-pushed
the
issue571-job-manager-db
branch
from
4b19919
to
1ce55e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step for issue #571 : allow user to specify a custom job database in run_jobs