Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Node Test Runner to Jest for compatibility #356

Draft
wants to merge 27 commits into
base: develop
Choose a base branch
from
Draft

Switch from Node Test Runner to Jest for compatibility #356

wants to merge 27 commits into from

Conversation

lemilonkh
Copy link
Contributor

  • Install jest
  • Setup and configure jest
  • Modify model tests to work with Jest
  • Remove unused config segments from jest.config.ts
  • Fix ESM module issues with jest by adjusting npm run test script
  • Fix ESM module issue in helpers.ts with import.meta.url
  • Convert city test to Jest

@evanp
Copy link
Contributor

evanp commented Mar 7, 2024

-1

What's going on here? Why would we make this kind of sweeping change?

@lemilonkh
Merge develop
861f335
@lemilonkh
Fix __dirname definition to not depend on __filename
2bdf7c3 
Not available in Jest
@lemilonkh
Install @jest/globals as a dev dependency
e45ae48
@lemilonkh
Extract type ApiResponse
aa08c8f
@lemilonkh
Create test helper expectStatusCode
aa844e3
@lemilonkh
Use expectStatusCode helper in userfile test
c92e249
@lemilonkh
Switch other npm test commands to jest
d9aa071
@lemilonkh
Set testEnvironment to node in jest config
4d98921
@lemilonkh
Reformat city test imports
ad379b7
@lemilonkh
Revert "Fix __dirname definition to not depend on __filename"
cf9b2c2 
This reverts commit 2bdf7c3.
@lemilonkh
Set NODE_ENV in npm test script
10c41ec
@lemilonkh
Rework inventory tests to use jest
5ab623c
@lemilonkh
Convert inventory value tests to Jest
65dac5a
@lemilonkh
Remove custom __dirname logic in helpers.ts
54a7de4
@lemilonkh
Fix misplaced await
afc072e
@lemilonkh
Handle internal server errors better in API error handler
de81f45
@lemilonkh
Remove unused import in inventory test
8f76538
@lemilonkh
Fix request text not being available in error case in inventory value…
6aed8d5 
… test
@lemilonkh
Transition population test suite to Jest
ed9d225
@lemilonkh
Configure setup files and worker threads in Jest to fix some of the B…
4160bcc 
…igInt issues
@lemilonkh lemilonkh self-assigned this May 27, 2024
@lemilonkh lemilonkh added enhancement New feature or request testing tooling labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cephaschapa cephaschapa Awaiting requested review from cephaschapa

At least 1 approving review is required to merge this pull request.

Assignees

@lemilonkh lemilonkh

Labels
enhancement New feature or request testing tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lemilonkh @evanp