Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): install Playwright for e2e tests and create e2e test for signup #456

Merged
merged 24 commits into from
Apr 24, 2024
Merged

feat(ci): install Playwright for e2e tests and create e2e test for signup #456

merged 24 commits into from
Apr 24, 2024

Conversation

lemilonkh
Copy link
Contributor

No description provided.

@lemilonkh lemilonkh self-assigned this Apr 22, 2024
@lemilonkh lemilonkh marked this pull request as draft April 22, 2024 11:49
@lemilonkh
fix(ci): run Playwright tests in app directory
e42ebe5
@lemilonkh
fix(ci): set default working directory to app and cache node dependen…
75d1704 
…cies
@lemilonkh
fix(ci): builder server before running Playwright tests
3e001e7
@lemilonkh
feat(ci): replace example test with signup test
12ffccd
@lemilonkh
fix(ci): move Playwright tests into normal test workflow
86e43ca
@lemilonkh
fix(ci): run unit tests first and install Playwright browsers before …
ed5627f 
…testing
@lemilonkh
feat(ci): add npm script e2e:test and update test script command
fc71166
@lemilonkh
feat(docs): add commands for e2e and unit tests to README.md
ca354a8
@lemilonkh
feat(script): add start-db.sh which starts a Docker Postgres instance…
25c8ad8 
… with the right config
@lemilonkh
feat(test): write e2e test for signup
ca1b5e1
@lemilonkh
fix(ci): add Playwright steps to develop and tag workflows for web
8f9a040
@lemilonkh lemilonkh changed the title WIP: install Playwright for e2e tests feat(ci): install Playwright for e2e tests and create e2e test for signup Apr 23, 2024
@lemilonkh lemilonkh marked this pull request as ready for review April 23, 2024 16:01
cephaschapa
cephaschapa approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@cephaschapa cephaschapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sign up page is a good starting point for E2E tests we could split up task to have other components tested as well. wdyt?

@lemilonkh lemilonkh merged commit 01d2a9a into develop Apr 24, 2024
3 checks passed
@lemilonkh lemilonkh deleted the feat/playwright branch April 24, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cephaschapa cephaschapa cephaschapa approved these changes

Assignees

@lemilonkh lemilonkh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lemilonkh @cephaschapa