Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer picker #4

Closed
gregallensworth opened this issue Apr 26, 2018 · 3 comments
Closed

Layer picker #4

gregallensworth opened this issue Apr 26, 2018 · 3 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@gregallensworth
Copy link
Contributor

At present there is no layer picker. Need to toggle historical state/county and to toggle modern state/county individually.

@gregallensworth gregallensworth self-assigned this Apr 26, 2018
@jeffreyameyer
Copy link

Should this be done with layers or styling at zoom levels? e.g. only show counties when zoomed in to roughly state level?

@gregallensworth
Copy link
Contributor Author

Layer visibility comes in two parts:

  • The availability of the layer at the given zoom level. With the data as-given from Newberry, State tiles cannot be generated without significant artifacts only up to z3, and Counties cannot start before z6. (not to say it's impossible, but would require significant contrivances not yet figured out, suited to a second round once the basic UI and UX are standing up)

    • Within the vectile configuration, the map knows not to try loading tiles for inappropriate zoom levels.
  • Setting the layer to visibility: none or visibility: visible This is what the layer control will do, so a user may manually choose to show historical states, modern states, historical counties, and modern counties in any combination.

    • Such a manual control, also lays a foundation for other layer adjustments not yet determined, such as opacity sliders, alternative basemaps, a choice of label overlay, additional reference layers not yet defined, ...

@jeffreyameyer
Copy link

I'm surprised to hear about the artifacts in the State-level Newberry data. Can you send a screenshot of what you're seeing? Here's an example of Kentucky that I think looks pretty good at about zoom = 9 or 10: https://imgur.com/a/HhbyTGA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants