Plot x-axis, y-axis, title, and color bar label sizes should be configurable. #573
Comments
|
Hello @ReimarBauer I am a bit unclear about this issue although I pondered over it for quite sometime. Is that the whole map with latitudes and longitudes that are already there need to be framed inside x and y axes or the waypoints colour and connecting flight path color needs to be configured? Please, make it a bit more clear. |
|
|
|
start with Plot x-axis, y-axis these are added by the client, see mpl_qtwidget. this PR can be taken as example how to add to the options menu and how axis are drawn https://github.com/Open-MSS/MSS/pull/980/files Also in that PR you can see the problem. Different users have different readable results. So an individual adjustment does help. |
|
I have read the PR#980 carefully. What I understood from this issue is that in the Sideview options menu, you want me to have the option of showing and hiding the x axis and y axis(both primary and secondary) as desirable. Am I right? This is necessary to have a clear display of the flightpath. Moreover, the sizes of the color label should be configurable(We can increase or decrease their sizes so as to have a clear visibility). Right? Please confirm if I understood the issue clearly or not. @ReimarBauer |
|
not ;) the PR is an example to show where and how options can be added. Also where the code lives for this issue. This issue is about to be able to change the font size for the labels of the x-axis, y-axis and the title. |
|
Thanks a lot for the clarification. Now that I have understood, I am looking onto it. |
ReimarBauer
added a commit
that referenced
this issue
Jun 2, 2021
… title) (#994) * ui_kmloverlay_dockwidget.ui file changed for showing color and linewidth of individual kml files * Changed the ui_kmloverlay_dockwidget.py added features of showing color and linewidth to this dockwidget (.py extension) file * Added functionality and connected slots to show the respective color and respective linewidth of individual kml files in the listwwidget( added changes to kmloverlay_dockwidget.py) * Modified 'remove_file(self)' function in kmloverlay_dockwidget.py ; added functionality for not showing color or linewidth when there are no kml files present in the listwidget * Instant changes/reflection to the color label and linewidth label when the color and linewidth is changed. And also previous code's optimization * Change color option added to main kmloverlay gui, editing of linewidth is direct in the main kmloverlay gui, display selected color of kml file right next to the file and the height of the colour block is in correspondence with the linewidth of that specific kml file * Discarded obsolete color label display and linewidth label. The icons were made to appear directly upon startup of kmloverlaywidget. On clicking kml files it shows linewidth and you can edit from there directly. * Optimized the code by setting flag to prevent the same icon being set twice because select_linewidth is called when item is clicked and also when valueChanged of spin box. Therefore, a flag is set to call select linewidth only when the value really changes. * flake8 test run successfuly without any errors * Improved functionality for setting color icons while adding files and tried the tests again * Modified test_kmloverlay_dockwidget.py test file and removed brackets from if() in kmloverlay_dockwidget.py * changes in test_wms_control/py for flake8 test to pass * Added features for hiding of linewidth & color options until a file is selected. Made linewidth editor box faster which was slowing down significantly. Made color change much faster. Modified the tests also. * Installed qt==5.9.7 and changed ui_kmloverlay_dockwidget.py and ui_kmloverlay_dockwidget.ui and removed the attribute setSteptype * Made Change Color button transparent. Added the current color of the KML file to the QColorDialog selected color. Shortened range of linewidth from 0.1 to 10 * Added .coverage to gitignore * Solved the issue #736 [Dock-widgets in TableView prevent TableView from closing upon application exit] - closing of tableview window when main MSS window is closed. Previously it used to stick around. But now it closes with MSS main window. * Made the code more understandable for solved issue #736 * Updating Merge Conflict * Synced with OpenMSS:develop * Added options in sideview to change the fontsize of x and y(both y) axes ticklabels and labels along with the plot title. * Rectified previous mistakes in gitignore file * Added fontsize configuration options for topview and added datasets for default size in MSSdefaultConfig so that user can put his default value. * Added plot options for LinearView, SideView, Topview and added default settings for users for those plot options. * Modified code to pass the tests. Co-authored-by: ReimarBauer <rb.proj@gmail.com>
Marilyth
pushed a commit
to Marilyth/MSS
that referenced
this issue
Jun 17, 2021
…and plot title) (Open-MSS#994) * ui_kmloverlay_dockwidget.ui file changed for showing color and linewidth of individual kml files * Changed the ui_kmloverlay_dockwidget.py added features of showing color and linewidth to this dockwidget (.py extension) file * Added functionality and connected slots to show the respective color and respective linewidth of individual kml files in the listwwidget( added changes to kmloverlay_dockwidget.py) * Modified 'remove_file(self)' function in kmloverlay_dockwidget.py ; added functionality for not showing color or linewidth when there are no kml files present in the listwidget * Instant changes/reflection to the color label and linewidth label when the color and linewidth is changed. And also previous code's optimization * Change color option added to main kmloverlay gui, editing of linewidth is direct in the main kmloverlay gui, display selected color of kml file right next to the file and the height of the colour block is in correspondence with the linewidth of that specific kml file * Discarded obsolete color label display and linewidth label. The icons were made to appear directly upon startup of kmloverlaywidget. On clicking kml files it shows linewidth and you can edit from there directly. * Optimized the code by setting flag to prevent the same icon being set twice because select_linewidth is called when item is clicked and also when valueChanged of spin box. Therefore, a flag is set to call select linewidth only when the value really changes. * flake8 test run successfuly without any errors * Improved functionality for setting color icons while adding files and tried the tests again * Modified test_kmloverlay_dockwidget.py test file and removed brackets from if() in kmloverlay_dockwidget.py * changes in test_wms_control/py for flake8 test to pass * Added features for hiding of linewidth & color options until a file is selected. Made linewidth editor box faster which was slowing down significantly. Made color change much faster. Modified the tests also. * Installed qt==5.9.7 and changed ui_kmloverlay_dockwidget.py and ui_kmloverlay_dockwidget.ui and removed the attribute setSteptype * Made Change Color button transparent. Added the current color of the KML file to the QColorDialog selected color. Shortened range of linewidth from 0.1 to 10 * Added .coverage to gitignore * Solved the issue Open-MSS#736 [Dock-widgets in TableView prevent TableView from closing upon application exit] - closing of tableview window when main MSS window is closed. Previously it used to stick around. But now it closes with MSS main window. * Made the code more understandable for solved issue Open-MSS#736 * Updating Merge Conflict * Synced with OpenMSS:develop * Added options in sideview to change the fontsize of x and y(both y) axes ticklabels and labels along with the plot title. * Rectified previous mistakes in gitignore file * Added fontsize configuration options for topview and added datasets for default size in MSSdefaultConfig so that user can put his default value. * Added plot options for LinearView, SideView, Topview and added default settings for users for those plot options. * Modified code to pass the tests. Co-authored-by: ReimarBauer <rb.proj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original report by Shawn Honomichl (Bitbucket: Shawn, GitHub: Shawn).
Plot x-axis, y-axis, title, and color bar label sizes should be configurable in the options. During briefings when flight plan images are displayed, people often complain of having trouble seeing labels.
The text was updated successfully, but these errors were encountered: