Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban IPs sending too many nodejoin messages #1

Closed
wants to merge 1 commit into from

Conversation

dystophia
Copy link

This patch blocks IPs sending too many nodejoin messages inside the verifier code.

Keep in mind this may introduce new issues as its using extra memory for the message counters / banned list.

@EggPool
Copy link

EggPool commented Apr 13, 2021

@dystophia Could it be possible to have this helpful addition be optional, by the way of extra preference entries?

Main thing would be to not consume extra ram via nodejoinCounters if not activated (say nodejoinBanThreshold=0, by default)

This way, we could merge into the CE but have it activated and tuned via preferences only, not adding extra risk or ram usage if deactivated.

@EggPool
Copy link

EggPool commented Nov 4, 2021

Thanks for that work,
it has been superseded by #8 , built upon your code.

Closing this one since the upgrade version is now merged.

@EggPool EggPool closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants