Improve Transaction Broadcasting for JSONRPC #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good! Waiting for potential feedback from the discord, then will merge. Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when broadcasting a transaction via the JSONRPC, the transaction is sent to all in-cycle verifiers. In Discord, NyzoSy pointed out that as the cycle grows, this may become inefficient.
In order to improve this, we will use
ClientTransactionUtil.sendTransactionToLikelyBlockVerifiers(ref) when broadcasting transactions via the JSONRPC.The change will broadcast the transaction to:
Please test! I do not currently have any accessible Nyzo to ensure it works as expected.
I am open to making changes and improvements. Thanks!