Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs (prestashop): added documentation for new plugin openpix + prestashop #763

Merged
merged 2 commits into from
Dec 21, 2023
Merged

docs (prestashop): added documentation for new plugin openpix + prestashop #763

merged 2 commits into from
Dec 21, 2023

Conversation

jefersoneiji
Copy link
Contributor

@jefersoneiji jefersoneiji commented Dec 18, 2023 •
edited
Loading

A few points to consider

  • For some reason prestashop name displays in lower case instead of uppser case. Would be nice to fix this before merging in docs.
  • Some screens shots are merely illustrative, as the plugin is yet to be published

daniloab
daniloab approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@daniloab daniloab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • steps podem començar no 1
  • consegue atualizar as imagens para ter o prefixo prestashop? ex `prestashop-set-up-0.png"
  • transformar os .PNG em .png

@jefersoneiji
docs (prestashop)!: added the prestashop prefix to images, counted st…
0844abe 
…eps starting from zero, and changed PNG to png
@jefersoneiji
Copy link
Contributor Author

jefersoneiji commented Dec 20, 2023 •
edited
Loading

  • steps podem començar no 1
  • consegue atualizar as imagens para ter o prefixo prestashop? ex `prestashop-set-up-0.png"
  • transformar os .PNG em .png

@daniloab publiquei o commit dessas mudanças.

@edumaciel10 edumaciel10 merged commit 69493ed into Open-Pix:main Dec 21, 2023
1 check passed
@jefersoneiji jefersoneiji deleted the prestashop-docs branch December 21, 2023 14:29
@jefersoneiji jefersoneiji mentioned this pull request Dec 22, 2023
Closed
This was referenced Jan 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloab daniloab daniloab approved these changes

@noghartt noghartt noghartt approved these changes

@edumaciel10 edumaciel10 edumaciel10 approved these changes

@Eckzzo Eckzzo Eckzzo approved these changes

@sibelius sibelius Awaiting requested review from sibelius sibelius is a code owner

@rturk rturk Awaiting requested review from rturk rturk is a code owner

@fersilva16 fersilva16 Awaiting requested review from fersilva16

@samueldurantes samueldurantes Awaiting requested review from samueldurantes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jefersoneiji @daniloab @noghartt @edumaciel10 @Eckzzo