Numeral watchface

[jessp01]

Hello all,

Well done on this excellent project.

I've created this watch face:

Would be glad to see it merged.

Cheers,

[RuffaloLavoisier]

Since we have a similar series watch, why don't we add the choose whether to display numbers in the web interface?

[uvwxy]

Since we have a similar series watch, why don't we add the choose whether to display numbers in the web interface?

I would be in favour of merging this as a separate watchface. As this uses additional fonts these would be added to the binary size of the OS even if the setting is not used.

By not including the watchfaces at compile time we can exclude additional, watchface specific dependencies at compile time, too.

[RuffaloLavoisier]

Since we have a similar series watch, why don't we add the choose whether to display numbers in the web interface?

I would be in favour of merging this as a separate watchface. As this uses additional fonts these would be added to the binary size of the OS even if the setting is not used.

By not including the watchfaces at compile time we can exclude additional, watchface specific dependencies at compile time, too.

As the Watchface increases, it takes a long time to find or manage the design you want, so you need to find a way to solve it.

[RuffaloLavoisier]

LGTM, Additionally, you must add this clock to the Web interface index.

[RuffaloLavoisier]

Corrected commit log.

[jessp01]

Hi all,

I didn't want to make changes to other watchface files without discussing it with you (the maintainers) but generally speaking, I'd be all for the below modifications and am happy to submit them if everyone agrees:

• One function to draw the numerals; this can accept the font to use (of course, we have to limit the selection to suitable fonts, can't use a 24pt one for example), coordinates, etc as parameters
• Expose a configuration that draws the numerals conditionally, which can then be checked in applicable watchfaces

If that sounds reasonable, which file should we include the numeral drawing function in? perhaps under include/apps/watchfaces/utils?

Additionally, I thought of adding the day of the month like so:

Lastly, @RuffaloLavoisier,

Sometimes this step-counter will not be readable by the user by the second hand of the clock.

Indeed, but I reckon that's true to many different designs, including the one in OswAppWatchfaceMonotimer (although far less frequently) and other smart watch projects as well. I can use a smaller font size for it but personally, I don't think it's too bad as is.
The same statement applies to displaying the day of the month, of course.

LGTM, Additionally, you must add this clock to the Web interface index.
Just so I'm sure, do you mean I should add it to https://github.com/Open-Smartwatch/open-smartwatch.github.io/blob/source/docs/index.md?

I'd also be open to contributing documentation on how to add watchfaces, which could help newcomers.

Thanks,

[RuffaloLavoisier]

LGTM, I'm happy to merge.

I'd also be open to contributing documentation on how to add watchfaces, which could help newcomers.

Thanks,

https://github.com/Open-Smartwatch/open-smartwatch-os/pull/288/files#diff-1eb7e6ee52c2add1ca7bafdf476d09de534e15be005de55cd51f235cc9f48c75R47

Please refer to this part And please write a brief introduction to this watch because we need to add it to the document (how does the number of steps look, the number of times of the week, etc.).

[RuffaloLavoisier]

Most of the time, the Watchface uses a variety of similar features and another watchfaces. Therefore, it is better to choose how to reuse the code rather than duplicate it.

And please update display date part :)

[jessp01]

Hi @RuffaloLavoisier,

Sorry, I've neglected to commit the changes I made to src/osw_config_keys.cpp before. Did so now.
Shall I also submit a pull to update https://github.com/Open-Smartwatch/open-smartwatch.github.io/blob/source/docs/index.md?

Most of the time, the Watchface uses a variety of similar features and another watchfaces. Therefore, it is better to choose how to reuse the code rather than duplicate it.

I agree but to me, it feels less desirable to rely on code implemented in other watchfaces which is why I made the suggestions in my last comment (#298 (comment)). Please let me know what you think.

And please update display date part :)

Updated. This too can be placed in a util function that can be then used in the different watch faces as per my last comment. Happy to refactor if you find this acceptable.

Thanks,

[RuffaloLavoisier]

Your commit is based on the master.
This merge builds up unnecessary commit logs.
I got it corrected commit log, but you force-push... 😆
Please use, if you need..

$ git fetch && git pull

[RuffaloLavoisier]

Sometimes this step-counter will not be readable by the user by the second hand of the clock.

which is why I made the suggestions in my last comment (#298 (comment)).

That comment is about the overlap between the number of steps and the hands of the clock. This is a (#298 (comment)) problem that makes code reuse, or repetitive code, difficult to maintain later

[RuffaloLavoisier]

Corrected the commit log again...

$ git pull

[RuffaloLavoisier]

LGTM - I've modified and organized some codes. There are more things to organize, but I think it would be okay to do it when I organize the watchface later.

[RuffaloLavoisier]

@jessp01
First, I'm sorry and thank you. It is sometimes good to modify internally like this.
As a result, thanks to your idea, we are able to merge the new watchface.
Thank you for your contribution.