Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Dimension Dimensionless per time not available in DimensionFactory." #246

Closed
PavelBal opened this issue Jan 9, 2020 · 11 comments
Closed

Comments

@PavelBal
Copy link
Member

PavelBal commented Jan 9, 2020

Please, please, please, finally add this dimension to the XML.

@msevestre
Copy link
Member

Isn't inverse time?

Why do you need this?

@msevestre
Copy link
Member

And what does it have to do with ospsuite-r?

@PavelBal
Copy link
Member Author

PavelBal commented Jan 9, 2020

Isn't inverse time?

No! See Open-Systems-Pharmacology/PK-Sim#827, Open-Systems-Pharmacology/PK-Sim#440, Open-Systems-Pharmacology/MoBi#379

And what does it have to do with ospsuite-r?

Because I cannot load models that have this dimension (and yes, my models still have this dimension)

@msevestre
Copy link
Member

Ok so that's a bug that was fixed
Open your pkml file and search replace dimension per time with InversedTime (check spelling before doing so). You should be good to go

@PavelBal
Copy link
Member Author

PavelBal commented Jan 9, 2020

So, I have to do it every time I export a pkml? Why not just add

  <Dimension name="Dimensionless per time" baseUnit="/min">
      <BaseRepresentation lengthExponent="0" massExponent="0" timeExponent="-1" electricCurrentExponent="0" temperatureExponent="0" amountExponent="0" luminousIntensityExponent="0" />
      <Units>
        <Unit name="/min" factor="1" />
      </Units>
    </Dimension>

To OSPSuite.Dimensions.xml?

@msevestre
Copy link
Member

you should not have it with a new version of MoBi.
We should not add it to the list because it will be visible in the list of dimension and it does not make sense.
If you have it again when exporting a new model from mobi to pkml, then the bug is not fixed

@PavelBal
Copy link
Member Author

PavelBal commented Jan 9, 2020

Yes, I still have it.

The project itself is rather old (pre-OSPS).

@msevestre
Copy link
Member

yeah nothing we can do in that case. At any rate, this also apply for all other dimensions that were misleadingly created by MoBi.

@PavelBal
Copy link
Member Author

yeah nothing we can do in that case.

You mean, the bug cannot be fixed?

At any rate, this also apply for all other dimensions that were misleadingly created by MoBi.

Yes.

@msevestre
Copy link
Member

The bug is fixed in Mobi. But old project won't work. We could potentially try to do a project conversion here but this needs to be done in MoBi

@msevestre
Copy link
Member

msevestre commented Jan 29, 2020

I am going to push a fix so that pkml will be converted even when there is this dimension. Can you let me know what other stupid wrong conversions you have found as well. I will submit a PR and you can comment their FYI @PavelBal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants