Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a field for the version of the standard the data is published to #157

Merged
merged 6 commits into from Nov 3, 2022

Conversation

duncandewhurst
Copy link
Collaborator

@duncandewhurst duncandewhurst commented Oct 24, 2022

Related issues
Add links to related issues here. Use keywords if you want an issue to be automatically closed when the PR is merged.

Description
If the changes in the PR are not sufficiently explained by the related issues and commit messages, add a description here

Also updates examples/csv/nodes.csv to reflect the change in 2e6d36c

Merge checklist

  • If there are changes to network-schema.json, network-package-schema.json, reference/publication_formats/json.md, reference/publication_formats/geojson.md or guidance/publication.md#how-to-publish-large-networks, update the relevant manually authored examples:
    • examples/json/:
      • network-package.json
      • api-response.json
      • multiple-networks.json
      • network-embedded.json
      • network-separate-endpoints.json
      • network-separate-files.json
      • nodes-endpoint.json
      • spans-endpoint.json
    • examples/geojson/:
      • api-response.geojson
      • multiple-networks.geojson
  • Run ./manage.py pre-commit to update derivative schema files, reference documentation and examples
  • If there are changes to examples/geojson/nodes.geojson or examples/geojson/spans.geojson, check and update the data use examples:
    • examples/leaflet/leaflet.ipynb
    • examples/qgis/geojson.qgs
  • Update the changelog (style guide)

@odscjames assigning to you for a review as I think this might be helpful to get merged before @lgs85 returns from leave.

odscjames
odscjames previously approved these changes Oct 25, 2022
@duncandewhurst
Copy link
Collaborator Author

Noting that this PR may need updating based on Open-Telecoms-Data/lib-cove-ofds#13 (comment)

@duncandewhurst
Copy link
Collaborator Author

@odscjames I've made the update discussed in Open-Telecoms-Data/lib-cove-ofds#13. Prior to draft 2020-12, tuple validation was handled differently so this schema will only behave as intended with validators that support draft 2020-12. jsonschema supports 2020-12 so hopefully that is not an issue for CoVE.

In order to permit only one 'describedby' link in links, I've added a pattern validation to Link.rel to permit any value except 'describedby'. However, I've run into the same issue as described in #145, whereby the regex does not behave as expected when I test it with https://www.jsonschemavalidator.net/. Any ideas?

@duncandewhurst
Copy link
Collaborator Author

@odscjames I've fixed the regex issue (thanks to @lgs85) so this is ready for you to review again. In particular, please check that you're happy with the use of JSON Schema 2020-12 described in my previous comment. Thanks!

odscjames
odscjames previously approved these changes Nov 2, 2022
@duncandewhurst
Copy link
Collaborator Author

I had to resolve a merge conflict in the changelog so another review is required.

@lgs85 lgs85 merged commit 667ace4 into 0.1-dev Nov 3, 2022
@lgs85 lgs85 deleted the 91-version-field branch November 3, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a field for the version of the standard the data is published to
3 participants