Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network-schema: Add unit to Span.fibreLength description #258

Merged
merged 3 commits into from May 8, 2023

Conversation

duncandewhurst
Copy link
Collaborator

@duncandewhurst duncandewhurst commented Apr 25, 2023

Related issues

Closes #254

Description

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit to update derivative schema files, reference documentation and examples

If there are changes to network-schema.json, network-package-schema.json, reference/publication_formats/json.md, reference/publication_formats/geojson.md or guidance/publication.md#how-to-publish-large-networks, update the relevant manually authored examples:

  • examples/json/:
    • network-package.json
    • api-response.json
    • multiple-networks.json
    • network-embedded.json
    • network-separate-endpoints.json
    • network-separate-files.json
    • nodes-endpoint.json
    • spans-endpoint.json
  • examples/geojson/:
    • api-response.geojson
    • multiple-networks.geojson

If you used a validation keyword, type or format that is not already used in the schema:

If you added a normative rule that is not encoded in JSON Schema:

If there are changes to examples/geojson/nodes.geojson or examples/geojson/spans.geojson, check and update the data use examples:

  • examples/leaflet/leaflet.ipynb
  • examples/qgis/geojson.qgs

@duncandewhurst duncandewhurst changed the base branch from 0.2-dev to 0.3-dev April 25, 2023 23:55
@duncandewhurst
Copy link
Collaborator Author

Once #259 is merged, then 0.3-dev can be merged into this branch to resolve the check failure.

@duncandewhurst duncandewhurst marked this pull request as ready for review May 2, 2023 21:53
@duncandewhurst duncandewhurst requested a review from rhiaro May 2, 2023 21:53
@duncandewhurst duncandewhurst merged commit 2849651 into 0.3-dev May 8, 2023
10 checks passed
@duncandewhurst duncandewhurst deleted the 254-fibreLength-unit branch May 8, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit to description of Span.fibreLength
2 participants