Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WKT for node locations and span routes #262

Merged
merged 10 commits into from May 8, 2023
Merged

Use WKT for node locations and span routes #262

merged 10 commits into from May 8, 2023

Conversation

duncandewhurst
Copy link
Collaborator

@duncandewhurst duncandewhurst commented Apr 26, 2023

Related issues

Description

TO-DO

  • Update publication format reference documentation
  • Check and update pre-commit command in manage.py
  • Consider updating descriptions for Node.location and Span.route to explain use of WKT for CSV files

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit to update derivative schema files, reference documentation and examples

If there are changes to network-schema.json, network-package-schema.json, reference/publication_formats/json.md, reference/publication_formats/geojson.md or guidance/publication.md#how-to-publish-large-networks, update the relevant manually authored examples:

  • examples/json/:
    • network-package.json
    • api-response.json
    • multiple-networks.json
    • network-embedded.json
    • network-separate-endpoints.json
    • network-separate-files.json
    • nodes-endpoint.json
    • spans-endpoint.json
  • examples/geojson/:
    • api-response.geojson
    • multiple-networks.geojson

If you used a validation keyword, type or format that is not already used in the schema:

If you added a normative rule that is not encoded in JSON Schema:

If there are changes to examples/geojson/nodes.geojson or examples/geojson/spans.geojson, check and update the data use examples:

  • examples/leaflet/leaflet.ipynb
  • examples/qgis/geojson.qgs

@duncandewhurst
Copy link
Collaborator Author

Once #259 is merged, then 0.3-dev can be merged into this branch to resolve the check failure.

@duncandewhurst duncandewhurst marked this pull request as ready for review May 2, 2023 21:52
@duncandewhurst duncandewhurst requested a review from rhiaro May 2, 2023 21:52
rhiaro
rhiaro previously approved these changes May 8, 2023
@duncandewhurst
Copy link
Collaborator Author

Merging without further review since the only change in a516512 was to resolve a conflict in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinates modelling (add support for WKT to Flatten Tool)
2 participants