Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary code #276

Merged
merged 3 commits into from Jun 28, 2023
Merged

Remove temporary code #276

merged 3 commits into from Jun 28, 2023

Conversation

duncandewhurst
Copy link
Collaborator

@duncandewhurst duncandewhurst commented Jun 27, 2023

Related issues

Description

There's a change to examples/csv/spans.csv because the WKT produced by the temporary code was missing some whitespace. There's also changes to examples/geojson/nodes.geojson and examples/geojson/spans.geojson because the old version of libcoveofds didn't dereference the organisation references in Node.networkProviders and Span.networkProviders.

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit to update derivative schema files, reference documentation and examples

(Removed irrelevant checklist items)

@duncandewhurst duncandewhurst marked this pull request as ready for review June 27, 2023 21:34
@duncandewhurst
Copy link
Collaborator Author

duncandewhurst commented Jun 27, 2023

Once this PR is merged, I can follow the steps in https://ofds-standard-development-handbook.readthedocs.io/en/latest/technical/deploy.html#merge-and-release to release version 0.3, which will resolve the linkcheck failure.

@Bjwebb Bjwebb merged commit 41addf3 into 0.3-dev Jun 28, 2023
16 of 20 checks passed
@Bjwebb Bjwebb deleted the remove-temporary-code branch June 28, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit: Remove temporary code once Flatten Tool and Lib Cove OFDS are updated
4 participants