-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent use of Nym vs Pseudonym in the API #200
Comments
+1 for Pseudonym everywhere. Or even something else maybe, that clarifies more what it is. |
+1 for Nym. The class is not really a Pseudonym in the way commonly understood: a short self-selected name. It's more about credentials and key management. It also is easier to type. People use |
+1 for Nym since it defines this ... concept in OT. Besides it's not really a pseudonym for anything. It's a transformation of the Source. Also |
The required changes can be grouped into these categories Method names
Additions 2014-10-01
The OTPseudonym class.Should be renamed to Serialized messages
Probably gets written somewhere as well Console output, comments, wiki, docsThis has lower priority in my opinion |
We should make a list of replacements and just do them all at once. eg,
I'm sure there's more than just this. |
I'm planing to write a tool that can help us with the |
BTW the first question I get from guys starting to work on opentxs is "what's a nym?". I think that both |
But it is not a I'm looking forward to the tool, is that something in the close future or shall I give it a whirl? |
Great discussion! :) To my understanding nym/pseudonym is just an identity. I.e. a user can have multiple identities. Question is if identity is too vague and too general. I also agree with @toxeus that it's probably too late to change to something completely different. Hence, we just decide on one of them. I prefer What do you think about this @FellowTraveler ? |
@murrekatt I don't think it is too late if we come up with a great name. We have to globally search/replace anyway so the replacement can be anything. If we have to tell people "Nyms/Psuedonyms are now called Foo" then Foo isn't such a great name :) Personally I think either of the existing names is fine. It's identity management that's conceptually difficult, the name is the least confusing part. |
Use Nym its already widespread in other crypto contexts and has been since the mid 90's ... if you look around. |
Yes, nym is the better of these two. Any other suggestions or is anyone very much against using nym? |
Let's put a deadline on this. Say 72 hours? If no one objects it's going to be 'nym'. |
24 hours is enough, especially since nearly all people already answered: |
A yes! Most excellent. 16 hours to go then. |
Pseudonym: pseudo (not); nym (name). In Open Transaction's case 'nym' really just is an aberration of 'pseudonym'. We don't mean 'nym' as in 'name'. The 'name' will be the 'unique-name' on namecoin, or the name you add for the particular pseudonym in your address book. Thus, calling it just 'nym' is somewhat misleading, at least from the Greek origins of the word. I would prefer to rename all cases to 'pseudonym', except for the cases where we explicitly need to use an abbreviated name; and that should be explained by a hover-over: "'nym' is the common aberration 'a pseudonym'". |
Thanks @da2ce7 for such a good argument. At this point I'm fine with either. Pro consistency. |
@da2ce7: "Aberration" - I think you meant to say "abbreviation." Regarding this issue: "Nym" is just an abbreviation for "pseudonym." If we have to choose one, I suggest Nym since it is shorter. Also: to add to the confusion, the code also uses "User" when it means "Nym." So I suggest changing "User" to "Nym" as well, in the code. Regarding the GUI: I've started using the term "Identities" in the GUI instead of "Nyms." The reason is because "Identities" doesn't require any explanation. ("Nym" is still more accurate, however.) Therefore I think we should use "Identities" in the GUI, and "Nym" everywhere in the code and API. |
Boom! It has been decided then. |
24 hours is way too short to assume a consensus. What planet are you on? For a global project, different time zones, different regions have different holidays, etc., where contributors are frequently travelling and accounting for weekends at a minimum 48 hours to notify. Assume a 48 hour delay plus 24 to respond, so 72 sounds about right. |
@FellowTraveler can we just call it "Identity" everywhere? I think that's the most descriptive term.
If we use "Nym" internally and "Identity" externally, that doesn't fix the issue. Internal people will keep calling it "Nym" out of habit, and forget to switch back in front of end-users. |
-1 on using Identity. Nyms have a property called "id" which is a hash of the public signing master key and is used all the time. So we'll end up talking about an "Identity-id" and have variables like Nym is better. |
(re-commenting with the right account this time) It's a tradeoff - code readability vs clear communication to end users. As long as we understand the tradeoff we're making, I'm ok with either choice. |
Jeff Weiss wrote:
The only reason we use "identity" in the GUI is because the layman can If we really have to choose a single term across both code and GUI, I'd |
We don't want everyone to have to figure out on their own that Pseudonyms and Nyms are the same thing.
All names of public entities (classes, concepts, etc) need to be consistent everywhere. Not just in the end-user interface but in the API and code (since we also don't want to confuse developers).
It's gruntwork to s/Pseudonym/Nym all over the code, wiki, and docs, but to leave it inconsistent looks pretty bad.
Doesn't matter to me which name we use in this case, but we should check for other inconsistent naming too.
The text was updated successfully, but these errors were encountered: