Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard coded MySql-ism from owa_column #600

Open
padams opened this issue May 12, 2020 · 1 comment
Open

Remove hard coded MySql-ism from owa_column #600

padams opened this issue May 12, 2020 · 1 comment
Assignees
@padams
Labels
Core Development Changes to framework or base module. Todo Maintenance things that need doing.
Milestone
1.7.1

Comments

@padams
Copy link
Collaborator

padams commented May 12, 2020

Description

owa_column::getDefinition contains a hard coded MySql-ism for specifying an INDEX.

Possible Solution

Move that sprintf statement to the mysql db plugin and replace with a constant like everything else.

Needed for #596
@padams padams added bug Bug in code confirmed and identified. Core Development Changes to framework or base module. labels May 12, 2020
@padams padams self-assigned this May 12, 2020
@padams padams added this to the 1.7.0 milestone May 12, 2020
@padams padams added Todo Maintenance things that need doing. and removed bug Bug in code confirmed and identified. labels May 12, 2020
@bernd-wechner
Copy link
Contributor

Postgresql support will hinge on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@padams padams

Labels
Core Development Changes to framework or base module. Todo Maintenance things that need doing.
Projects
None yet
Milestone
1.7.1
Development

No branches or pull requests
2 participants
@padams @bernd-wechner