New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Heatmap & domstream fixes #567
Conversation
@Maaiins Your earlier commit in #534 broken heat maps as both heat maps and domstreams use the same |
Shit didn´t recognized that. Was working fine when i tested it... |
var width = jQuery(this).data('width'); | ||
|
||
var windowFeatures = "menubar=yes,location=yes,resizable=no,scrollbars=yes,status=yes,height=" + height + ",width=" + width; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn´t came up with that idea, very nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Pull request checklist
Please check if your PR fulfills the following requirements:
/path/to/php cli.php cmd=build
) was run locally and any changes were pushedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Docs need to be updated?