RFC: Rewrite _v2-entry-point in Python #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, those scripts will just be ignored so all the client has to do is execute our launcher. I agree though, it's not clear to me if a custom solution will be worth the maintenance effort... |
Oh right, got it, I didn't think that through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our launchers shells out to two shell scripts -- _v2-entry-point (ULWGL), run or run-in-sniper. This doesn't seem to be a problem and is perfectly fine to just leave it, however this PR demonstrates that it doesn't have to be that way as it's fairly trivial to implement in Python. Whether the benefits, if there is any, warrants the rewrite is left open to debate. Until there's a consensus, this PR will be left in a draft state.
Related to #8