Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor oacd_freeswitch #96

Open
lordnull opened this issue Jul 17, 2012 · 0 comments
Open

Refactor oacd_freeswitch #96

lordnull opened this issue Jul 17, 2012 · 0 comments
Labels

Comments

@lordnull
Copy link
Member

Primarily freeswitch_media, but some apply to all. The problems are:

  • no unit tests: Using meck as a stand-in for the freeswitch module should make this easier.
  • code duplication: freeswitch_media shares code with freeswitch_ring as well as freeswitch_dialer. Freeswitch_media_manager and freeswitch_monitor share some code. It seems like much of that can be abstracted out, to improve code re-use and ease future freeswitch developement.
  • flawed apis: The freeswitch_media conference calls do not give useful return values. If a conference fails, the client is never informed. Those calls should be turned into calls that return a success or failure. This can be done using the freeswitch module, but requires changes to how agents communicate with freeswitch; the cpx_agent_connection module is mean to ease this type of communication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant