Skip to content

Commit

Permalink
zynqmp_a53: Convert '&' to '&&' operator in if statement
Browse files Browse the repository at this point in the history
Fix incorrect test in if statement by replacing bitwise AND
with logical AND operation.

Found using Coccinelle.

Semantic Patch Language (SmPL) used:

<smpl>

@@
expression E1, E2;
@@

- !E1 & !E2
+ !E1 && !E2

</smpl>

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
  • Loading branch information
himanshujha199640 authored and wjliang committed Oct 29, 2018
1 parent 82e26fb commit 89276b5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions lib/system/freertos/zynqmp_a53/sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ unsigned int sys_irq_save_disable(void)

void metal_machine_cache_flush(void *addr, unsigned int len)
{
if (!addr & !len)
if (!addr && !len)
Xil_DCacheFlush();
else
Xil_DCacheFlushRange((intptr_t)addr, len);
}

void metal_machine_cache_invalidate(void *addr, unsigned int len)
{
if (!addr & !len)
if (!addr && !len)
Xil_DCacheInvalidate();
else
Xil_DCacheInvalidateRange((intptr_t)addr, len);
Expand Down
4 changes: 2 additions & 2 deletions lib/system/generic/zynqmp_a53/sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ unsigned int sys_irq_save_disable(void)

void metal_machine_cache_flush(void *addr, unsigned int len)
{
if (!addr & !len)
if (!addr && !len)
Xil_DCacheFlush();
else
Xil_DCacheFlushRange((intptr_t)addr, len);
}

void metal_machine_cache_invalidate(void *addr, unsigned int len)
{
if (!addr & !len)
if (!addr && !len)
Xil_DCacheInvalidate();
else
Xil_DCacheInvalidateRange((intptr_t)addr, len);
Expand Down

0 comments on commit 89276b5

Please sign in to comment.