Wrap vars ifndef #236
Closed
Wrap vars ifndef #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentheredonethat
force-pushed
the
wrap_vars_ifndef
branch
from
59a48ab
to
3447d3c
Compare
Allow Shared memory, TTC and IPI values to be set dynamically. This will enable the demos to be run on different platforms. Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
Allow Shared memory, TTC and IPI values to be set dynamically. This will enable the demos to be run on different platforms. Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
Allow Shared memory, TTC and IPI values to be set dynamically. This will enable the demos to be run on different platforms. Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
bentheredonethat
force-pushed
the
wrap_vars_ifndef
branch
from
3447d3c
to
b85879a
Compare
|
the error here does not seem to apply to the patches given. please review the set when able. this makes it so we can configure the apps via cmake and thus the demos more scalable. i understand there is a pending move to system-reference repo for apps. since the apps have not yet been moved, can we review and merge here first and then at the time of the move we can then begin to send patches to the new repo? thanks |
tnmysh
approved these changes
Jun 1, 2023
|
Ben, @TanmayShah-xilinx, This PR contradicts two decisions:
|
|
closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable demos to be configured via CMake configure or toolchain file.
This enables the demos to be configured for Versal and Versal_Net platforms.