Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vim editor configuration in files #264

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Remove vim editor configuration in files #264

merged 1 commit into from
Oct 17, 2023

Conversation

arnopo
Copy link
Contributor

@arnopo arnopo commented Oct 13, 2023

Remove all remaining instances of "# vim: ..." in files

@arnopo arnopo added this to the Release V2023.10 milestone Oct 13, 2023
tnmysh
tnmysh reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@tnmysh tnmysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with the change.

However, do we know why they were introduced in the first place?
May be we can give reasons in commit message and then remove it.

@arnopo
Copy link
Contributor Author

arnopo commented Oct 16, 2023

I am okay with the change.

However, do we know why they were introduced in the first place? May be we can give reasons in commit message and then remove it.

This is part of the initial commit. I suppose that the author(s) of the first verion of libmetal was using vim or gvim, which automatically add this line...

@arnopo
Remove vim editor configuration in files
7f68828 
Remove all remaining instances of "# vim: ..." in files.
This vim settings were part of the initial commit. But no reason
to keep them.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
@arnopo arnopo requested a review from tnmysh October 16, 2023 14:15
tnmysh
tnmysh approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@tnmysh tnmysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arnopo arnopo merged commit 9fe00e0 into OpenAMP:main Oct 17, 2023
4 checks passed
@arnopo arnopo deleted the rm_vim branch October 25, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tammyleino tammyleino tammyleino approved these changes

@tnmysh tnmysh tnmysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release V2023.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arnopo @tammyleino @tnmysh