Skip to content

Commit

Permalink
virtqueue: remove shm_io argument from virtqueue_create()
Browse files Browse the repository at this point in the history
Remove shared memory I/O region argument from virtqueue_create() API.
The virtqueue I/O region can be set in another APIs.

Signed-off-by: Wendy Liang <jliang@xilinx.com>
  • Loading branch information
wjliang committed May 29, 2018
1 parent 5a27357 commit 99ffe0b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion lib/include/openamp/virtqueue.h
Expand Up @@ -177,7 +177,6 @@ int virtqueue_create(struct virtio_device *device, unsigned short id,
const char *name, struct vring_alloc_info *ring,
void (*callback) (struct virtqueue * vq),
void (*notify) (struct virtqueue * vq),
struct metal_io_region *shm_io,
struct virtqueue *v_queue);

/*
Expand Down
1 change: 0 additions & 1 deletion lib/rpmsg/remote_device.c
Expand Up @@ -436,7 +436,6 @@ int rpmsg_rdev_create_virtqueues(struct virtio_device *dev, int flags, int nvqs,
status =
virtqueue_create(dev, idx, (char *)names[idx], &ring_info,
callbacks[idx], hil_vring_notify,
rdev->proc->sh_buff.io,
vqs[idx]);

virtqueue_set_shmem_io(vqs[idx], rdev->proc->sh_buff.io);
Expand Down
3 changes: 0 additions & 3 deletions lib/virtio/virtqueue.c
Expand Up @@ -35,7 +35,6 @@ static int virtqueue_nused(struct virtqueue *vq);
* when message is available on VirtIO queue
* @param notify - Pointer to notify function, used to notify
* other side that there is job available for it
* @param shm_io - shared memory I/O region of the virtqueue
* @param vq - Created VirtIO queue.
*
* @return - Function status
Expand All @@ -44,7 +43,6 @@ int virtqueue_create(struct virtio_device *virt_dev, unsigned short id,
const char *name, struct vring_alloc_info *ring,
void (*callback) (struct virtqueue * vq),
void (*notify) (struct virtqueue * vq),
struct metal_io_region *shm_io,
struct virtqueue *vq)
{
int status = VQUEUE_SUCCESS;
Expand All @@ -63,7 +61,6 @@ int virtqueue_create(struct virtio_device *virt_dev, unsigned short id,
vq->vq_free_cnt = vq->vq_nentries;
vq->callback = callback;
vq->notify = notify;
vq->shm_io = shm_io;

/* Initialize vring control block in virtqueue. */
vq_ring_init(vq, (void *)ring->vaddr, ring->align);
Expand Down

0 comments on commit 99ffe0b

Please sign in to comment.