Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio: follow virtio 1.2 spec, add more virtio status and device id #493

Merged
merged 1 commit into from Jun 22, 2023

Conversation

CV-Bowen
Copy link
Contributor

@CV-Bowen CV-Bowen commented Jun 4, 2023

Summay

Follow virtio v1.2 spec, add more virtio status and device id. I change the device id from hexadecimal to decimal, because the virtio v1.2 spec use decimal.

Make commit 1 in #489 be an independent PR.

Impact

Should be none.

@arnopo
Copy link
Collaborator

arnopo commented Jun 5, 2023

@CV-Bowen
Please fix your commit message.
s/From: wangbowen6 wangbowen6@xiaomi.com/From: Bowen Wang wangbowen6@xiaomi.com/

Have a description of your update

@CV-Bowen CV-Bowen force-pushed the virtio-spec-only branch 4 times, most recently from 2cbede2 to 1a07cd6 Compare June 13, 2023 02:05
@CV-Bowen
Copy link
Contributor Author

@arnopo Done

lib/include/openamp/virtio.h Outdated Show resolved Hide resolved
lib/virtio/virtio.c Show resolved Hide resolved
Follow the virtio v1.2 spec, add more virtio status and device id
definition in virtio.h

Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@danmilea danmilea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge.

@arnopo arnopo merged commit b177618 into OpenAMP:main Jun 22, 2023
2 checks passed
@arnopo arnopo linked an issue Jun 22, 2023 that may be closed by this pull request
@arnopo arnopo added this to the Release V2023.10 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

what's plan to support the service/driver at the virtio level?
3 participants