Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move apps dir from the open-amp repository #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move apps dir from the open-amp repository #19

wants to merge 1 commit into from

Conversation

kernelchuk
Copy link

My first attempt to move the apps based on our discussions about libmetal examples. Please, see: OpenAMP/libmetal#231.

@kernelchuk kernelchuk force-pushed the mv_oapps branch 2 times, most recently from 0cb624c to 5b41fac Compare August 29, 2023 02:29
@arnopo
Copy link
Collaborator

arnopo commented Aug 31, 2023

@wmamills, @edmooring, @tnmysh, @glneo:

This PR simply moves the application folder from the library, which I believe is a step in the right direction.

As we have rejected #15, I want first to confirm that everyone is okay with this PR.

The middle -term objectives (from my point of view) is to:

  • First, clean up libraries by removing applications and tests (which is the objective of this PR).
  • Second, enhance the baremetal/FreeRtos applications to support non-AMD platforms.

Is everyone is Ok with that plan?

@tnmysh
Copy link
Collaborator

tnmysh commented Aug 31, 2023

@wmamills, @edmooring, @tnmysh, @glneo:

This PR simply moves the application folder from the library, which I believe is a step in the right direction.

As we have rejected #15, I want first to confirm that everyone is okay with this PR.

The middle -term objectives (from my point of view) is to:

  • First, clean up libraries by removing applications and tests (which is the objective of this PR).
  • Second, enhance the baremetal/FreeRtos applications to support non-AMD platforms.

Is everyone is Ok with that plan?

Thanks @arnopo, I am okay with this plan.

@kernelchuk
Move apps dir from the open-amp repository
82ffd72 
Move apps directory from https://github.com/OpenAMP/open-amp
Moved directories:
apps
|-- examples
|   |-- echo
|   |-- linux_rpc_demo
|   |-- load_fw
|   |-- matrix_multiply
|   |-- nocopy_echo
|   |-- rpc_demo
|   `-- rpmsg_sample_echo
|-- machine
|   |-- microblaze_generic
|   |-- zynq7
|   |-- zynqmp
|   `-- zynqmp_r5
|-- system
|   |-- generic
|   |   `-- machine
|   |       |-- microblaze_generic
|   |       |-- zynq7
|   |       `-- zynqmp_r5
|   `-- linux
|       `-- machine
|           |-- generic
|           `-- zynqmp
`-- tests
    `-- msg

Signed-off-by: Sergei Korneichuk <sergei.korneichuk@amd.com>
@kernelchuk
Copy link
Author

kernelchuk commented Sep 16, 2023 •
edited

Hi @arnopo, @wmamills, @edmooring, @glneo:

I have been up-streaming AMD’s internal commits to achieve the “upstream first” status, i.e., our internal forks have minimum divergence from the GitHub. Our largest delta is in the examples, which are frozen in OpenAMP (see OpenAMP/libmetal#23) pending the move to this repo.

@arnopo posted two objectives. The first one is clear and easy to understand. I think the second objective should be a community effort, i.e.: the example code grandfathered in the first step will have to adopt a new common/platform-specific framework. This framework is yet to be defined.

My management approves my work to:

  1. Move the examples:
  2. Convert them to the new common framework when it’s defined by the community.

Can we, please, clarify if the second objective (support non-AMD platforms) is or is-not a precondition to the move?

@arnopo arnopo mentioned this pull request Sep 19, 2023
Open
@arnopo
Copy link
Collaborator

arnopo commented Sep 27, 2023

Hi @arnopo, @wmamills, @edmooring, @glneo:

I have been up-streaming AMD’s internal commits to achieve the “upstream first” status, i.e., our internal forks have minimum divergence from the GitHub. Our largest delta is in the examples, which are frozen in OpenAMP (see OpenAMP/libmetal#23) pending the move to this repo.

@arnopo posted two objectives. The first one is clear and easy to understand. I think the second objective should be a community effort, i.e.: the example code grandfathered in the first step will have to adopt a new common/platform-specific framework. This framework is yet to be defined.

My management approves my work to:

  1. Move the examples:

  2. Convert them to the new common framework when it’s defined by the community.

Can we, please, clarify if the second objective (support non-AMD platforms) is or is-not a precondition to the move?

Sorry for the delay, we are still discussing on the way we do do it. Come back to you ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kernelchuk @arnopo @tnmysh