Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #25

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Update README.md #25

merged 1 commit into from
Dec 4, 2021

Conversation

hkawa608
Copy link
Contributor

@hkawa608 hkawa608 commented Nov 8, 2021

Added sha256 of openapi-generator-cli-5.1.0.jar.
Since a version and sha256 are hardcoded at https://github.com/OpenAPITools/openapi-generator-bazel/blob/master/internal/openapi_generator.bzl#L5, sha256 should be also specified along with openapi_generator_cli_version.

Added sha256 of openapi-generator-cli-5.1.0.jar.
Since a version and sha256 are hardcoded at https://github.com/OpenAPITools/openapi-generator-bazel/blob/master/internal/openapi_generator.bzl#L5, sha256 should be also specified along with openapi_generator_cli_version.
@wing328
Copy link
Member

wing328 commented Dec 4, 2021

@hkawa608 thanks for the PR, which looks good to me.

Sorry for the delay in reviewing.

Have a nice weekend.

@wing328 wing328 merged commit 2103017 into OpenAPITools:master Dec 4, 2021
@hkawa608 hkawa608 deleted the patch-2 branch December 8, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants