[php] make ObjectSerializer::toString actually return a string (#12158)

OpenAPITools · Apr 20, 2022 · 8a83a34 · 8a83a34
1 parent fbdd3c3
commit 8a83a34
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 3 deletions.
diff --git a/modules/openapi-generator/src/main/resources/php/ObjectSerializer.mustache b/modules/openapi-generator/src/main/resources/php/ObjectSerializer.mustache
@@ -260,7 +260,7 @@ class ObjectSerializer
         } elseif (is_bool($value)) {
             return $value ? 'true' : 'false';
         } else {
-            return $value;
+            return (string) $value;
         }
     }
 

diff --git a/samples/client/petstore/php/OpenAPIClient-php/.openapi-generator/FILES b/samples/client/petstore/php/OpenAPIClient-php/.openapi-generator/FILES
@@ -59,14 +59,14 @@ docs/Model/SpecialModelName.md
 docs/Model/Tag.md
 docs/Model/User.md
 git_push.sh
+lib/ApiException.php
 lib/Api/AnotherFakeApi.php
 lib/Api/DefaultApi.php
 lib/Api/FakeApi.php
 lib/Api/FakeClassnameTags123Api.php
 lib/Api/PetApi.php
 lib/Api/StoreApi.php
 lib/Api/UserApi.php
-lib/ApiException.php
 lib/Configuration.php
 lib/HeaderSelector.php
 lib/Model/AdditionalPropertiesClass.php

diff --git a/samples/client/petstore/php/OpenAPIClient-php/lib/ObjectSerializer.php b/samples/client/petstore/php/OpenAPIClient-php/lib/ObjectSerializer.php
@@ -269,7 +269,7 @@ public static function toString($value)
         } elseif (is_bool($value)) {
             return $value ? 'true' : 'false';
         } else {
-            return $value;
+            return (string) $value;
         }
     }
 

diff --git a/samples/client/petstore/php/OpenAPIClient-php/tests/ObjectSerializerTest.php b/samples/client/petstore/php/OpenAPIClient-php/tests/ObjectSerializerTest.php
@@ -334,4 +334,44 @@ public function provideDeepObjects(): array
             ],
         ];
     }
+
+    /**
+     * @dataProvider provideToStringInput
+     */
+    public function testToString($input, string $expected): void
+    {
+        $result = ObjectSerializer::toString($input);
+
+        $this->assertSame($expected, $result);
+    }
+
+    public function provideToStringInput(): array
+    {
+        return [
+            'int' => [
+                'input' => 1,
+                'expected' => '1',
+            ],
+            'int 0' => [
+                'input' => 0,
+                'expected' => '0',
+            ],
+            'false' => [
+                'input' => false,
+                'expected' => 'false',
+            ],
+            'true' => [
+                'input' => true,
+                'expected' => 'true',
+            ],
+            'some string' => [
+                'input' => 'some string',
+                'expected' => 'some string',
+            ],
+            'a date' => [
+                'input' => new \DateTime('14-04-2022'),
+                'expected' => '2022-04-14T00:00:00+00:00',
+            ],
+        ];
+    }
 }