Skip to content

Commit

Permalink
[swift5 client] fix filename for binary downloads (#9989)
Browse files Browse the repository at this point in the history
* fix-filename-from-header-response-retrieval: fix early exit of iteration

before a match could be found

* fix-filename-from-header-response-retrieval: fixed same bug for alamofire usage too

* fix-filename-from-header-response-retrieval: build project and update samples

Co-authored-by: Christopher Gretzki <gretzki@adesso-mobile.de>
  • Loading branch information
gretzki and gretzki committed Jul 21, 2021
1 parent 1d64822 commit d23915a
Show file tree
Hide file tree
Showing 15 changed files with 15 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ private var managerStore = SynchronizedDictionary<String, Alamofire.SessionManag
let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ private var urlSessionStore = SynchronizedDictionary<String, URLSession>()
let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ open class AlamofireRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ internal class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

let filenameKey = "filename="
guard let range = contentItem.range(of: filenameKey) else {
break
continue
}

filename = contentItem
Expand Down

0 comments on commit d23915a

Please sign in to comment.