Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] PHP 7.4 end of life #14152

Closed
ybelenko opened this issue Nov 30, 2022 · 6 comments
Closed

[php] PHP 7.4 end of life #14152

ybelenko opened this issue Nov 30, 2022 · 6 comments

Comments

@ybelenko
Copy link
Contributor

It's me again 🤣
PHP 7.4 reached end of life at 28 Nov 2022

End of life - A release that is no longer supported. Users of this release should upgrade as soon as possible, as they may be exposed to unpatched security vulnerabilities.

PHP: Supported Versions:

  • 7.4 until 28 Nov 2022
  • 8.0 until 26 Nov 2023
  • 8.1 until 26 Nov 2024

It seems that we need to change minimum PHP version to php: ^8.0 in all php generators. We should not only change composer requirement, but check with extra caution that Composer actually can resolve all the deps under PHP 8.0. In other words check that generator builds and actually works.

Current Requirements:

Generator PHP version
php client ^7.4 || ^8.0
Laravel server >= 7.2.5
Lumen server >= 7.2.5
Slim4 server ^7.4 || ^8.0
Symfony server >=7.4.0|>=8.0.2
php-mezzio-ph server ^ 7.3 || ^8.0
php-mezzio-ph-modern server ^8.0
php-dt client ^7.3 || ^8.0
php-dt-modern client ^8.0

cc @jebentier @dkarlovi @mandrean @jfastnacht @renepardon
cc @Articus as author of php-mezzio-ph, php-mezzio-ph-modern, php-dt client, php-dt-modern client

@Articus
Copy link
Contributor

Articus commented Dec 1, 2022

It's me again 🤣

Thanks for keeping track of that 👍🏻

Firstly a small clarification - php-mezzio-ph-modern server and php-dt-modern client are not separate generators. modern is just a flag that can be set via cli arguments --additional-properties=modern=true. And the question of dropping 7.4 support is a bit tricky because of that. It requires a huge choice - either drop modern option completely or introduce a new meaning for it (for example PHP 8.1 enumeration support).

Hopefully I'll find some free time to work on this till the end of the month.

@hugofintecture
Copy link
Contributor

hugofintecture commented Jul 5, 2023

@ybelenko can be closed no?

@ybelenko
Copy link
Contributor Author

ybelenko commented Jul 5, 2023

@ybelenko can be closed no?

I'm not sure that we changed minimum PHP version across all PHP generators. I keep that issue as reminder.

@NiklasBr
Copy link

NiklasBr commented Sep 1, 2023

Is there a way to use php-nextgen generator in v7.0.0 today? Seems not since I get the error "Can't load config class with name 'php-nextgen'"

But is there a docker image available with php-nextgen beta?

@wing328
Copy link
Member

wing328 commented Sep 2, 2023

I've filed #16480.

@ybelenko
Copy link
Contributor Author

ybelenko commented Jan 2, 2024

Closed in favour #17508

@ybelenko ybelenko closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@NiklasBr @Articus @wing328 @ybelenko @hugofintecture and others