Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-nextgen] Set minimal PHP version to ^8.0 #14500

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

ybelenko
Copy link
Contributor

I would even set PHP ^8.1 since it has new key features like union of types public setTarget(SomeClass | AnotherClass $target) which is very handy to use from the first day. It could also reduce maintain burden(support one version instead of two). But I assume that community wants to cover all current PHP version, so be it "php": ^8.0.

Related #14152

In the next PR I'm gonna add strict_types declaration and extend PHP-CS-Fixer config a lot. It can cause huge PR with huge diffs because it obviously will update code style in all samples.
Also want to add phplint package for quick syntax check and CI.
Then long refactoring discussed with @wing328. William wants to port fromJson, toJson, toDict, fromDict methods from python-nextgen and hide data serialization in ApiClient then user don't need to be aware of ObjectSerializer anymore. My personal goal is to use new PHP features. Second goal is to use interfaces as much as possible, to be more specific I want new php client to be easy configurable via PHP-DI container. Maybe we finally can stop depending on GuzzleClient and use PSR HttpClient interface instead.

I didn't check generated TravisCI config since I don't use it anymore(I like GitHub Actions more recently), but their online compiler says that syntax is correct.

cc @Articus @jebentier @dkarlovi @mandrean @jfastnacht @renepardon

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ybelenko ybelenko changed the title Set minimal PHP version to ^8.0 [php] Set minimal PHP version to ^8.0 Jan 21, 2023
@wing328
Copy link
Member

wing328 commented Mar 13, 2023

let's do it !

@wing328 wing328 merged commit a4540fe into OpenAPITools:php-nextgen Mar 13, 2023
@wing328 wing328 added this to the 6.5.0 milestone Mar 13, 2023
@ybelenko ybelenko deleted the php-nextgen-14152 branch March 14, 2023 16:53
@ybelenko ybelenko changed the title [php] Set minimal PHP version to ^8.0 [php-nextgen] Set minimal PHP version to ^8.0 Apr 7, 2023
@plozmun
Copy link

plozmun commented Aug 1, 2023

Why this feature is not in the beta7.0 branch? is there a way to use this branch (php-nexthen).

Thanks

wing328 added a commit that referenced this pull request Sep 3, 2023
* php-nextgen first commit

* [php] Set minimal PHP version to ^8.0 (#14500)

* Set minimal PHP version to ^8.0

* Fix php-nextgen config

* Change stability to BETA

* Add phplint package (#15054)

* [php-nextgen] Rename folders to follow PDS skeleton (#15102)

* Change lib -> src, test -> tests folder

This will make build compliant to PHP-PDS skeleton.
Ref: https://github.com/php-pds/skeleton

* Refresh samples

* Exclude composer.lock from codebase (#15105)

Since client generator is library and not a project it makes sense
to exclude composer.lock from codebase by default.

Ref: http://getcomposer.org/doc/02-libraries.md#lock-file

* Add @generated tag to DocBlocks (#15106)

This tag in draft status right now(PSR-19), but I think we can leverage
from it already.

Ref: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-generated

* update samples, doc

* update samples

---------

Co-authored-by: Yuriy Belenko <yura-bely@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants