Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][jaxrs-jersey] unnecessary multipart imports in generated code #1421

Open
kingofdisasterr opened this issue Nov 13, 2018 · 0 comments
Open

Comments

@kingofdisasterr
Copy link

Description

if the java jaxrs-jersey server code is generated from a model which doesn't need the jersey multipart feature, the multipart packages are imported anyway.

openapi-generator version

openapi-generator 3.3.2

OpenAPI declaration file content or url
openapi: 3.0.1
info:
  title: foo
  description: >-
    bar
  version: 1.1.0
paths:
  /foo/v1/bar:
    get:
      summary: read foo bar
      operationId: getFooBar
      responses:
        200:
          content:
            application/json:
              schema:
                default:
          description: all went ok
Command line used for generation

Java -jar openapi-generator-cli-3.3.2.jar generate -i /foobar.yaml -g jaxrs-jersey -o /foobar

java output
package fooBar.impl;

import fooBar.*;
import fooBar.model.*;


import java.util.List;
import fooBar.NotFoundException;

import java.io.InputStream;

import org.glassfish.jersey.media.multipart.FormDataContentDisposition;

import javax.ws.rs.core.Response;
import javax.ws.rs.core.SecurityContext;
import javax.validation.constraints.*;
@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaJerseyServerCodegen", date = "2018-11-12T10:51:46.203+01:00[Europe/Berlin]")
public class FooApiServiceImpl extends FooApiService {
    @Override
    public Response getFooBar(SecurityContext securityContext) throws NotFoundException {
        // do some magic!
        return Response.ok().entity(new ApiResponseMessage(ApiResponseMessage.OK, "magic!")).build();
    }
}
Suggest a fix/enhancement

in the templates should be a check around the multipart imports:

{{#useMultipartFeature}}
import org.glassfish.jersey.media.multipart.FormDataContentDisposition;
import org.glassfish.jersey.media.multipart.FormDataParam;
{{/useMultipartFeature}}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant