-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] [php-laravel] Writes file database/migrations/2019_08_19_000000 twice #18831
Closed
1 of 6 tasks
Labels
Comments
Philzen
added a commit
to Philzen/openapi-generator
that referenced
this issue
Jun 2, 2024
Re-enable when OpenAPITools#18831 is fixed
Philzen
added a commit
to Philzen/openapi-generator
that referenced
this issue
Jun 2, 2024
5 tasks
Philzen
added a commit
to Philzen/openapi-generator
that referenced
this issue
Jun 2, 2024
Re-enable when OpenAPITools#18831 is fixed
Philzen
added a commit
to Philzen/openapi-generator
that referenced
this issue
Jun 2, 2024
Re-enable when OpenAPITools#18831 is fixed
wing328
pushed a commit
that referenced
this issue
Jun 4, 2024
…cs (#18816) * Implement test for uniqueness of CliOptions across all generators * Refactor existing test to use @dataProvider and fluent assertion * Remove extraneous cliOption definition for disallowAdditionalPropertiesIfNotPresent This is already defined (matching exactly in all aspects) in DefaultCodegen. Resolves #18810 * Avoid variable declaration & assignment when only used once * Add additional uniqueness tests for all DefaultCodegen List<> members Test uniqueness for lists of: - supportingFiles - supportedLibraries - supportedVendorExtensions * Disable AllGeneratorsTest.noDuplicateSupportingFiles for the time being Re-enable when #18831 is fixed * Generate updated python-fastapi docs
Philzen
added a commit
to Philzen/openapi-generator
that referenced
this issue
Jun 4, 2024
welshm
pushed a commit
to welshm/openapi-generator
that referenced
this issue
Jun 5, 2024
…cs (OpenAPITools#18816) * Implement test for uniqueness of CliOptions across all generators * Refactor existing test to use @dataProvider and fluent assertion * Remove extraneous cliOption definition for disallowAdditionalPropertiesIfNotPresent This is already defined (matching exactly in all aspects) in DefaultCodegen. Resolves OpenAPITools#18810 * Avoid variable declaration & assignment when only used once * Add additional uniqueness tests for all DefaultCodegen List<> members Test uniqueness for lists of: - supportingFiles - supportedLibraries - supportedVendorExtensions * Disable AllGeneratorsTest.noDuplicateSupportingFiles for the time being Re-enable when OpenAPITools#18831 is fixed * Generate updated python-fastapi docs
welshm
pushed a commit
to welshm/openapi-generator
that referenced
this issue
Jun 5, 2024
…itten twice (OpenAPITools#18832) * Implement dedicated transitional test for OpenAPITools#18831 bugfix * Remove duplicated database migration file from supportingFiles collection * Activate AllGeneratorsTest.noDuplicateSupportingFiles * Drop transitional test again * Simplify truthy assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not really a bug that should concern anyone as the file gets simply overwritten on the second time.
But since it implies bot extraneous code and write operations, it should be dropped.
A test that checks for duplicates in the
supportedFiles
array is introduced via #18816, but currently disabled due to this.Bug Report Checklist
openapi-generator version
7.7.0-SNAPSHOT
The text was updated successfully, but these errors were encountered: