Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [php-laravel] Writes file database/migrations/2019_08_19_000000 twice #18831

Closed
1 of 6 tasks
Philzen opened this issue Jun 2, 2024 · 0 comments · Fixed by #18832
Closed
1 of 6 tasks

[BUG] [php-laravel] Writes file database/migrations/2019_08_19_000000 twice #18831

Philzen opened this issue Jun 2, 2024 · 0 comments · Fixed by #18832
Labels
Issue: Bug

Comments

@Philzen
Copy link
Contributor

Philzen commented Jun 2, 2024 •
edited

Not really a bug that should concern anyone as the file gets simply overwritten on the second time.

But since it implies bot extraneous code and write operations, it should be dropped.

A test that checks for duplicates in the supportedFiles array is introduced via #18816, but currently disabled due to this.

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
openapi-generator version

7.7.0-SNAPSHOT
@Philzen Philzen changed the title [BUG] [php-laravel] Writes file migrations/2019_08_19_000000 twice [BUG] [php-laravel] Writes file database/migrations/2019_08_19_000000 twice Jun 2, 2024
Philzen added a commit to Philzen/openapi-generator that referenced this issue Jun 2, 2024
@Philzen
Disable AllGeneratorsTest.noDuplicateSupportingFiles for the time being
2234991 
Re-enable when OpenAPITools#18831 is fixed
Philzen added a commit to Philzen/openapi-generator that referenced this issue Jun 2, 2024
@Philzen
Implement dedicated regression test for OpenAPITools#18831
95d5931
@Philzen Philzen mentioned this issue Jun 2, 2024
Merged
5 tasks
Philzen added a commit to Philzen/openapi-generator that referenced this issue Jun 2, 2024
@Philzen
Disable AllGeneratorsTest.noDuplicateSupportingFiles for the time being
5354bba 
Re-enable when OpenAPITools#18831 is fixed
Philzen added a commit to Philzen/openapi-generator that referenced this issue Jun 2, 2024
@Philzen
Disable AllGeneratorsTest.noDuplicateSupportingFiles for the time being
f95408c 
Re-enable when OpenAPITools#18831 is fixed
wing328 pushed a commit that referenced this issue Jun 4, 2024
@Philzen
[python-fastapi] Fix CLI crash when calling config-help & update do…
35a8820 
…cs (#18816)

* Implement test for uniqueness of CliOptions across all generators

* Refactor existing test to use @dataProvider and fluent assertion

* Remove extraneous cliOption definition for disallowAdditionalPropertiesIfNotPresent

This is already defined (matching exactly in all aspects) in DefaultCodegen.

Resolves #18810

* Avoid variable declaration & assignment when only used once

* Add additional uniqueness tests for all DefaultCodegen List<> members

Test uniqueness for lists of:
- supportingFiles
- supportedLibraries
- supportedVendorExtensions

* Disable AllGeneratorsTest.noDuplicateSupportingFiles for the time being

Re-enable when #18831 is fixed

* Generate updated python-fastapi docs
Philzen added a commit to Philzen/openapi-generator that referenced this issue Jun 4, 2024
@Philzen
Implement dedicated transitional test for OpenAPITools#18831 bugfix
889ab1c
Philzen added a commit that referenced this issue Jun 5, 2024
@Philzen
[php-laravel] Fix file database/migrations/2019_08_19_000000 being wr…
45bc9c9 
…itten twice (#18832)

* Implement dedicated transitional test for #18831 bugfix

* Remove duplicated database migration file from supportingFiles collection

* Activate AllGeneratorsTest.noDuplicateSupportingFiles

* Drop transitional test again

* Simplify truthy assertions
welshm pushed a commit to welshm/openapi-generator that referenced this issue Jun 5, 2024
@Philzen @welshm
[python-fastapi] Fix CLI crash when calling config-help & update do…
7c0747f 
…cs (OpenAPITools#18816)

* Implement test for uniqueness of CliOptions across all generators

* Refactor existing test to use @dataProvider and fluent assertion

* Remove extraneous cliOption definition for disallowAdditionalPropertiesIfNotPresent

This is already defined (matching exactly in all aspects) in DefaultCodegen.

Resolves OpenAPITools#18810

* Avoid variable declaration & assignment when only used once

* Add additional uniqueness tests for all DefaultCodegen List<> members

Test uniqueness for lists of:
- supportingFiles
- supportedLibraries
- supportedVendorExtensions

* Disable AllGeneratorsTest.noDuplicateSupportingFiles for the time being

Re-enable when OpenAPITools#18831 is fixed

* Generate updated python-fastapi docs
welshm pushed a commit to welshm/openapi-generator that referenced this issue Jun 5, 2024
@Philzen @welshm
[php-laravel] Fix file database/migrations/2019_08_19_000000 being wr…
ffbf3c6 
…itten twice (OpenAPITools#18832)

* Implement dedicated transitional test for OpenAPITools#18831 bugfix

* Remove duplicated database migration file from supportingFiles collection

* Activate AllGeneratorsTest.noDuplicateSupportingFiles

* Drop transitional test again

* Simplify truthy assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Bug
Projects
None yet
Milestone
No milestone
1 participant
@Philzen