Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [typescript-angular] local package installation fails because of link issue #1988

Closed
3 tasks
MBcom opened this issue Jan 25, 2019 · 3 comments
Closed
3 tasks

Comments

@MBcom
Copy link
Contributor

MBcom commented Jan 25, 2019

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • [x ] What's the version of OpenAPI Generator used?
  • [ x] Have you search for related issues/PRs?
  • [x ] What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description
  • if you install the generated typescript angular package locally like described in the README.md then you ran in trouble on windows if the version of the api packages changes
  • so installing the build tgz bundle instead induced npm to copy the generated files to the node_modules folder instead of symlinking them

the bug bevaviour is actually described in the README.md

the linked pull request solves this issue

openapi-generator version

4.0.0

OpenAPI declaration file content or url
Command line used for generation
Steps to reproduce

run

npm install --save <Path to api package>

change something on the api package, do some git commits on an other machine like an unix based system, pull the changes and install the new api package again - the new changes are not adopted
see angular/angular-cli#8284

Related issues/PRs

look at the linked pr

Suggest a fix

look at the linked pr

@auto-labeler
Copy link

auto-labeler bot commented Jan 25, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@karismann
Copy link
Contributor

this can be closed cause it has been fixed with 4.0.0 (linked PR)

@wing328 wing328 closed this as completed May 20, 2019
@wing328
Copy link
Member

wing328 commented May 20, 2019

@karismann thanks for going through issues and make sure their status is up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants