-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][jaxrs 2.1/resteasy] compilation error because of @PATCH #2018
Comments
Thank you for opening this issue. The JaxRS generator needs some love anyway... See #27. In thorntail it would be much better to use MicroProfile OpenAPI but we do not have the generator for it yet. I agree with your idea for the patch, having Can you send a Pull Request for that? Let me know if you need help. |
Thanks. |
@jmini @wing328 I have sent a Pull Request. Unfortunately the tests failed on CircleCI (https://circleci.com/gh/OpenAPITools/openapi-generator/4576#tests/containers/2) . |
Also facing the same issue while generating code thorugh OpenAPI Plugin. It says "@patch" is ambiguous, whicl results in compilation error. |
Hi, The same problem for us. Br, Tim |
It is working fine with openapi 4.0.0 beta4 version .
Also with version with 3.3.4 +io swagger parser 2.0.Latset_version.
…On 09-May-2019 1:41 PM, "Tim wu" ***@***.***> wrote:
Hi,
The same problem for us.
Br,
Tim
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2018 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALMOSAKMDSIW44AUD4TO5B3PUPMCNANCNFSM4GS7KABA>
.
|
Thanks for your info, beta4 haven't uploaded to the Maven central yet, I
will wait and test it.
Br,
Tim
sachinpipal <notifications@github.com> 于2019年5月9日周四 下午2:47写道:
… It is working fine with openapi 4.0.0 beta4 version .
Also with version with 3.3.4 +io swagger parser 2.0.Latset_version.
On 09-May-2019 1:41 PM, "Tim wu" ***@***.***> wrote:
> Hi,
>
> The same problem for us.
>
> Br,
>
> Tim
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#2018 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ALMOSAKMDSIW44AUD4TO5B3PUPMCNANCNFSM4GS7KABA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2018 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI5O7PWBHKKZ3LIS7WITZLPUQL5BANCNFSM4GS7KABA>
.
|
Sorry for the typoe its beta3 actually
…On 10-May-2019 11:06 AM, "Tim wu" ***@***.***> wrote:
Thanks for your info, beta4 haven't uploaded to the Maven central yet, I
will wait and test it.
Br,
Tim
sachinpipal ***@***.***> 于2019年5月9日周四 下午2:47写道:
> It is working fine with openapi 4.0.0 beta4 version .
> Also with version with 3.3.4 +io swagger parser 2.0.Latset_version.
>
> On 09-May-2019 1:41 PM, "Tim wu" ***@***.***> wrote:
>
> > Hi,
> >
> > The same problem for us.
> >
> > Br,
> >
> > Tim
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
> #2018#
issuecomment-490798102
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe-auth/
ALMOSAKMDSIW44AUD4TO5B3PUPMCNANCNFSM4GS7KABA
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#2018#
issuecomment-490887259>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AAI5O7PWBHKKZ3LIS7WITZLPUQL5BANCNFSM4GS7KABA>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2018 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALMOSAN6C4QTFN5MYKPT7VDPUUCWRANCNFSM4GS7KABA>
.
|
Beta3 contains another problem, something related to "duplicated
parameters" #2631
sachinpipal <notifications@github.com> 于2019年5月10日周五 上午7:40写道:
… Sorry for the typoe its beta3 actually
On 10-May-2019 11:06 AM, "Tim wu" ***@***.***> wrote:
> Thanks for your info, beta4 haven't uploaded to the Maven central yet, I
> will wait and test it.
>
> Br,
> Tim
>
> sachinpipal ***@***.***> 于2019年5月9日周四 下午2:47写道:
>
> > It is working fine with openapi 4.0.0 beta4 version .
> > Also with version with 3.3.4 +io swagger parser 2.0.Latset_version.
> >
> > On 09-May-2019 1:41 PM, "Tim wu" ***@***.***> wrote:
> >
> > > Hi,
> > >
> > > The same problem for us.
> > >
> > > Br,
> > >
> > > Tim
> > >
> > > —
> > > You are receiving this because you commented.
> > > Reply to this email directly, view it on GitHub
> > > <
> > #2018#
> issuecomment-490798102
> > >,
> > > or mute the thread
> > > <
> > https://github.com/notifications/unsubscribe-auth/
> ALMOSAKMDSIW44AUD4TO5B3PUPMCNANCNFSM4GS7KABA
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <#2018#
> issuecomment-490887259>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AAI5O7PWBHKKZ3LIS7WITZLPUQL5BANCNFSM4GS7KABA>
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#2018 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ALMOSAN6C4QTFN5MYKPT7VDPUUCWRANCNFSM4GS7KABA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2018 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI5O7NMTWMEY7RKQQMRWSLPUUDGJANCNFSM4GS7KABA>
.
|
Bug Report Checklist
Description
By default, @patch annotation is resolved to package io.swagger.jaxrs.* .
PATCH annotation was not part of jaxrs 2.0 specifications ( https://jax-rs.github.io/apidocs/2.1/ ) but it is now part of jaxrs 2.1 specifications (https://jax-rs.github.io/apidocs/2.1/).
Compilation with jaxrs 2.1 leads to a compilation failure because of imports with wild cards for both packages io.swagger.jaxrs.* and javax.ws.rs.* .
openapi-generator version
3.3.3
OpenAPI declaration file content or url
Command line used for generation
Steps to reproduce
The issue occurs when we upgrade our thorntail dependency from 2.2.0 (2.2.0) to 2.3.0 (jarxrs 2.1).
Related issues/PRs
Suggest a fix
The suggested fix is to replace @patch in the generated source code by @io.swagger.jaxrs.PATCH.
By the way, the generated source will compile for any jaxrs version.
As a work around, we use the com.google.code.maven-replacer-plugin:replacer maven plugin in order to update the generated source code on the fly. Of course we have to apply it everywhere @patch is generated.
The text was updated successfully, but these errors were encountered: