Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][KOTLIN][Retrofit2] Generator should support optional header parameter #8809

Closed
4 of 6 tasks
alitams opened this issue Feb 23, 2021 · 1 comment · Fixed by #9306
Closed
4 of 6 tasks

[BUG][KOTLIN][Retrofit2] Generator should support optional header parameter #8809

alitams opened this issue Feb 23, 2021 · 1 comment · Fixed by #9306

Comments

@alitams
Copy link

alitams commented Feb 23, 2021

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

Header parameters can be optional, like path parameters. See the code below. What I experience, despite of the required attribute is false, it generates the parameter as required. I expect that it should be optional with null default value.

Experienced:

@PUT("verify")
fun verify(@Body verifyRequest: VerifyRequest, @Header("Token") verifyData: String): Single<VerifyResponse>

Expected:

@PUT("verify")
fun verify(@Body verifyRequest: VerifyRequest, @Header("Token") verifyData: String? = null): Single<VerifyResponse>
openapi-generator version

5.0.1

OpenAPI declaration file content or url
   /verify:
    put:
      tags:
        - verify
      operationId: verifyData
      parameters:
        - $ref: '#/components/parameters/optionalToken'
      requestBody:
        content:
          application/json:
            schema:
              $ref: "#/components/schemas/VerifyRequest"
        required: true
      responses:
        "200":
          description: Successfully verifed
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/VerifyResponse"

components:
  parameters:
    optionalToken:
      name: Token
      in: header
      required: false
      description: OptionalToken description
      schema:
        type: string
Suggest a fix

The kotlin-client/libraries/jvm-retrofit2/headerParams.mustache should be changed from this:

{{#isHeaderParam}}@Header("{{baseName}}") {{{paramName}}}: {{{dataType}}}{{/isHeaderParam}}

to this:

{{#isHeaderParam}}@Header("{{baseName}}") {{paramName}}: {{{dataType}}}{{#required}}{{#defaultValue}} = {{{.}}}{{/defaultValue}}{{/required}}{{^required}}?{{#defaultValue}} = {{{.}}}{{/defaultValue}}{{^defaultValue}} = null{{/defaultValue}}{{/required}}{{/isHeaderParam}}
@shanselm-ergon
Copy link
Contributor

Same issue here.

I like your proposal, I'll create a pull request for it.

shanselm-ergon added a commit to ergon/openapi-generator that referenced this issue Apr 21, 2021
shanselm-ergon added a commit to ergon/openapi-generator that referenced this issue Apr 21, 2021
shanselm-ergon added a commit to ergon/openapi-generator that referenced this issue Apr 21, 2021
shanselm-ergon added a commit to ergon/openapi-generator that referenced this issue Apr 22, 2021
wing328 pushed a commit that referenced this issue May 20, 2021
#9306)

* [Kotlin] [#8809] Allow optional header parameters with Kotlin and retrofit2

* [Kotlin] [#8809] Update sample client

* [Kotlin] [#8809] Replace mustache dot notation with more classic style

* [Kotlin] [#8809] Remove new line at the end of the mustache template
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this issue May 26, 2021
…tlin and ret… (OpenAPITools#9306)

* [Kotlin] [OpenAPITools#8809] Allow optional header parameters with Kotlin and retrofit2

* [Kotlin] [OpenAPITools#8809] Update sample client

* [Kotlin] [OpenAPITools#8809] Replace mustache dot notation with more classic style

* [Kotlin] [OpenAPITools#8809] Remove new line at the end of the mustache template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants