[BUG] [typescript-angular] Add "header" to reserved words #10091
Conversation
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) |
There was a problem hiding this comment.
Thanks for your contribution @JohnTraDolta !
I like the approach here.
There is a smallish issue - some of the original variables names are listed as "reveserved" here. But the new names are not listed. So it's possible to get a conflict with those now (although rather unlikely, it would be a regression).
However, perhaps it would be better to have a separate cleanup PR across various typescript generators
wing328
changed the title
* master: (849 commits) Don't use encodeCollectionQueryParameter on maps (OpenAPITools#10116) Fixed the utc time issue for httpSigning auth. (OpenAPITools#10139) [dart][dio] Update built_value to =>8.1.0 (OpenAPITools#10122) Add Inquisico to list of generator users (OpenAPITools#10142) add my companies to README (OpenAPITools#10146) [C][Client] Allocate memory for the element of array when the type is number (OpenAPITools#10124) update samples Fixed typo in csharp-netcore httpclient generated code (OpenAPITools#10119) Typescript-angular: Added missing semi colon to interface export in `apis.ts` template file. (OpenAPITools#10121) Fix issue 10020: [BUG] [typescript-angular] Add "header" to reserved words (OpenAPITools#10091) Add missing samples for OpenAPITools#9857 [typescript] FIX: Generate documentation and examples OpenAPITools#9413 (OpenAPITools#9857) Feat adds has discriminator with non empty mapping (OpenAPITools#9667) Add switches (authentication collections) to support files (OpenAPITools#9884) [dart-dio-next] improve encodeCollectionQueryParameter to handle cases where collectionFormat is null (OpenAPITools#10105) [go-server] Feat: add required assertions to models (OpenAPITools#10068) [dart2] Include request body on DELETE call (OpenAPITools#10100) Make php's array a primitive (OpenAPITools#10093) Fix typo (preffer -> prefer) (OpenAPITools#10098) Fix typo on rust client (OpenAPITools#10096) ...
Renamed the local variabels as agreed upon with @wing328, as a solution to #10020