Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart][dio] Nullable parameters & defaults for header/query parameters #10147

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

kuhnroyal
Copy link
Contributor

  • respect the nullable flag for all parameters (except path params where this is not allowed)
  • generate default values for header and query parameters that are not collections
  • we can not handle default values for collection with built_value atm. (not const)
  • we can not handle default values for form/body parameters atm. as those can be enums which we can not construct easily

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC: @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob

* respect the nullable flag for all parameters (except path params where this is not allowed)
* generate default values for header and query parameters that are not collections
* we can not handle default values for collection with built_value atm. (not const)
* we can not handle default values for form/body parameters atm. as those can be enums which we can not construct easily
@wing328 wing328 merged commit 5fe76c2 into OpenAPITools:master Aug 15, 2021
@kuhnroyal kuhnroyal deleted the dart-dio/parameter-defaults branch August 16, 2021 09:09
@kuhnroyal
Copy link
Contributor Author

Sadly this contains a bug... this can generate a required String foo = 'bar' parameter which is invalid.

kuhnroyal added a commit to kuhnroyal/openapi-generator that referenced this pull request Aug 16, 2021
wing328 pushed a commit that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants