Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby][Faraday]Update default timeout of Faraday request to 60 seconds #10401

Closed
wants to merge 2 commits into from

Conversation

NivathaSV8
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Sep 15, 2021

@NivathaSV8 thanks for the PR. What's the reason behind the update?

@NivathaSV8 NivathaSV8 changed the title Update default timeout of Faraday request to 60 seconds [Ruby][Faraday]Update default timeout of Faraday request to 60 seconds Sep 16, 2021
@NivathaSV8
Copy link
Contributor Author

@wing328 Closed the previously created PR. Fixed the issue #10137.

@NivathaSV8 NivathaSV8 closed this Sep 16, 2021
@NivathaSV8 NivathaSV8 deleted the fix_issue_101037 branch September 16, 2021 06:10
@NivathaSV8 NivathaSV8 restored the fix_issue_101037 branch September 16, 2021 06:12
@NivathaSV8
Copy link
Contributor Author

Since the branch name refers to wrong issue id, create new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants