Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated model generation, addProps handling moved into type object and anyType handling #10505

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 1, 2021

Updated model generation, addProps handling moved into type object and anyType handling
additionalProperties are only meaningful when schema type is anyType or object
so process them in only in those use cases.

  • updateModelForComposedSchema made protected so generators can override it if they choose

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether added this to the 5.3.0 milestone Oct 1, 2021
@spacether
Copy link
Contributor Author

CircleCi error was unrelated, retrying it

@spacether spacether merged commit 638a2fa into OpenAPITools:master Oct 1, 2021
@spacether spacether deleted the feat_updates_addProps_handling_in_fromModel branch October 19, 2021 05:34
@wing328 wing328 removed the java label Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants