Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: replace @ with at_ to allow properties like @type and type at the same time #10521

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

jens1205
Copy link
Contributor

@jens1205 jens1205 commented Oct 4, 2021

in case the open-api-specification contains a property "@type" as well as "type", this leads to duplicate struct attributes ("type_").
@frol @farcaller @richardwhiuk @paladinzh

I'd suggest to generate a leading @ as "at_" to solve this issue.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Oct 13, 2021

A better approach is to leverage specialCharReplacements mapping. We can do it later with another PR.

@wing328 wing328 merged commit 3d0d1d5 into OpenAPITools:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants