Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart: mark jaguar for deprecation #10533

Merged

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Oct 5, 2021

Dart jaguar doesn't work with newer versions of Dart, there are no contributors to this generator, and it doesn't even generate correct code #5583.

I suggest marking it as deprecated and removing in the future, only changes in last 12 months were forced maintenance changes to keep it in sync with other Dart generators.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@agilob
Copy link
Contributor Author

agilob commented Oct 5, 2021

@agilob agilob changed the title Dart mark jaguar for deprecation Dart: mark jaguar for deprecation Oct 5, 2021
@jaumard
Copy link
Contributor

jaumard commented Oct 5, 2021

weird pretty sure @wing328 already deprecate it

@jaumard
Copy link
Contributor

jaumard commented Oct 5, 2021

but all good for me!

@wing328 wing328 added this to the 5.3.0 milestone Oct 5, 2021
@wing328 wing328 merged commit 8d7be74 into OpenAPITools:master Oct 5, 2021
@agilob agilob deleted the dart-mark-jaguar-for-deprecation branch October 5, 2021 17:39
@kuhnroyal
Copy link
Contributor

Yea we already did that some time ago, must have gotten lost in one of the version branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants