Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds inline composition examples to python-experimental #11420

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jan 26, 2022

openapi-generator has trouble processing inline composed schemas
When it detects a complicated inline schema, it extracts it into a new component with an inline model resolver
Sometimes it does not extract the schema though and the complicated schema remains inline.
A complicated schema could be a schema with validations or composition, anything other than a simple type or type + format combination.
python-experimental was built to allow full-featured schemas at any depth (root, inline at depth 1, 2 3 etc). Schema constraints will work whether or not a schema is extracted into a component or remains inline.

This PR

  • adds inline composition examples to python-experimental to verify that the python-experimental generator is gracefully handling these inline schema use cases
  • Feature: adds response body decoding of multipart/form-data note: json boundary content-types are not yet supported; they can be added in the future

When these samples work, it will close out:
#8457
because we will now have a python language generator which supports this inline composition use case.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether force-pushed the feat_addsInlineCompositionExamplesToPythonExp branch from 31fdbdf to e32997a Compare February 1, 2022 19:30
@spacether spacether added this to the 6.0.0 milestone Feb 3, 2022
@spacether spacether merged commit 4d9a500 into OpenAPITools:master Feb 3, 2022
@spacether spacether deleted the feat_addsInlineCompositionExamplesToPythonExp branch February 3, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant