Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] fix deserialization of readonly properties #11495

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

borsch
Copy link
Member

@borsch borsch commented Feb 2, 2022

Fix for #10167 (comment)
Workaround that will skip @JsonDeserialize(as = LinkedHashSet.class) over nullable Set (the one with JsonNullable)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Feb 7, 2022

Thanks for the PR. Can you please PM me via https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g when you've time?

@wing328 wing328 merged commit 25270a0 into OpenAPITools:master Feb 12, 2022
@@ -0,0 +1,10 @@
generatorName: spring
library: spring-boot
outputDir: samples/server/petstore/spring-boot-nullable-set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. Add the path to github workflow via 4c330f4

@borsch borsch deleted the 10167-fix-nullable-set branch March 17, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants